maemo.org Bugzilla – Bug 901
osso_thumbnail_factory_load() needs destroy callback
Last modified: 2009-10-22 07:56:30 UTC
You need to
before you can comment on or make changes to this bug.
This is actually in the osso-thumbnail module, but I can't find a bugzilla
product or component for that.
osso_thumbnail_factory_load() needs a destroy callback, which would be called
when the user_data should be destroyed.
Usually the user_data would be released in the regular
OssoThumbnailFactoryFinishedCallback callback (assuming it is called only once,
which should be documented), but that might never be called if I call
Here is an example of a GTK+ function that has that:
osso-thumbnail is now Marius' package.
Reassign the bug to the correct component (osso-thumbnail)
Note that the osso-thumbnail bugzilla component needs to be renamed to a
Marius: any news here?
(In reply to comment #3)
> Note that the osso-thumbnail bugzilla component needs to be renamed to a
> hildon-thumbnail component.
renamed the component and updated its description. (osso-thumbnail was renamed
to hildon-thumbnail for version 0.9) Thanks for the heads up.
Created an attachment (id=939) [details]
This patch adds two functions, hildon_thumbnail_factory_load_full and
hildon_thumbnail_factor_load_custom_full that add a GDestroyNotify parameter.
It is called to free the user_data when the corresponding thumb item is freed.
WONTFIX for Diablo (no ressources currently).
hildon-thumbnail has received some refactoring in Fremantle, so it's worth to
recheck if the patch still applies and makes sense in
so I can ping again to get this in for Fremantle.
The patch does not apply against hildon-thumbnail from SVN. However,
hildon_thumbnail_factory_load() has been deprecated anyway, in favor of
hildon_thumbnail_factory_request_uri() both of which have a destroy notify
I could update the patch of course, but I wonder whether it is even needed.
Agreed. The new function and the deprecation correct this problem.
We will just not wrap the deprecated functions in the C++ bindings.
(In reply to comment #9 by Armin)
> However, hildon_thumbnail_factory_load() has been deprecated anyway, in favor
> of [...] which have a destroy notify callback.
(In reply to comment #10 by Murray)
> Agreed. The new function and the deprecation correct this problem.
--> Closing as FIXED for Fremantle; thanks for updating the ticket.
Marking patches of interest to Diablo (Maemo4) community updates, please excuse