First Last Prev Next    No search results available
Bug 8791 - After editing User_talk: page, two "You have new messages (last change)." banners are on each wiki page.
: After editing User_talk: page, two "You have new messages (last change)." ban...
Status: RESOLVED FIXED
Product: maemo.org Website
Wiki
: unspecified
: All Maemo
: Unspecified normal (vote)
: ---
Assigned To: Ferenc Szekely
: midgard@maemo.org
:
:
:
:
  Show dependency tree
 
Reported: 2010-02-02 20:53 UTC by Matan Ziv-Av
Modified: 2010-03-22 17:03 UTC (History)
2 users (show)

See Also:

Attachments
Example wiki page with the banners. (18.87 KB, text/html)
2010-02-02 20:53 UTC, Matan Ziv-Av 		Details
Add an attachment (proposed patch, testcase, etc.)


Note

You need to log in before you can comment on or make changes to this bug.

Description Matan Ziv-Av (reporter) 2010-02-02 20:53:09 UTC 
SOFTWARE VERSION:

EXACT STEPS LEADING TO PROBLEM: 
1. Edit User_talk page. For example (http://wiki.maemo.org/User_talk:Matan).
2. Browse wiki logged in (as Matan).

EXPECTED OUTCOME:
One "You have new messages (last change)." banner appears on one wiki page.

ACTUAL OUTCOME:
Two "You have new messages (last change)." banners are on each wiki page.

REPRODUCIBILITY:
always.

EXTRA SOFTWARE INSTALLED:

OTHER COMMENTS:

The banners still appear, even though the page was last edited on 21/01/2010,
and even though I visited both links in the banners.


User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; es-ES; rv:1.9.1.7)
Gecko/20100106 Ubuntu/9.10 (karmic) Firefox/3.5.7
Comment 1 Matan Ziv-Av (reporter) 2010-02-02 20:53:59 UTC 
Created an attachment (id=2199) [details]
Example wiki page with the banners.
Comment 2 Ryan Abel maemo.org 2010-02-03 15:00:58 UTC 
Regression and dupe of bug #3235, maybe?
Comment 3 Dave Neary maemo.org 2010-02-05 13:41:47 UTC 
My analysis of the issue:

1. In maemo2midgard/mediawiki/2009/MonoBookMaemo2009.php, we have the user
messages included once only, after the start of <div id="main-wrapper">:
260                         <?php if($this->data['newtalk'] ) { ?><div
class="usermessage"><?php $this->html('newtalk')  ?></div><?php } ?>

2. No sign of a second test for $this->data['newtalk'] just after the body tag.
So the second message must come from an extension that's hooking in to
mediawiki (in the same way that the "Edit Help" extension does:
http://wiki.maemo.org/User:Dneary#.22Edit_help.22_extension

3. No evidence in the maemo2midgard module of how newtalk gets set and unset.
In a stock MediaWiki this problem doesn't exist, so I can guess that there are
some patches to the stock MediaWiki in Maemo's instance. However, I don't know
yet where it's installed, and it doesn't appear to be in source control (*if*
there are changes).
Comment 4 Dave Neary maemo.org 2010-02-12 02:18:47 UTC 
I just verified that the MonoBookMaemo2009.php which is live on wiki.maemo.org
isn't the same one that is in svn.

I'll check differences later, and see how different they are.

Still no good idea why 'newtalk' isn't getting unset when I visit my Talk page.
Comment 5 Dave Neary maemo.org 2010-02-12 02:25:35 UTC 
Further investigation: mediawiki/includes/User.php has an mtime of 2010-01-07,
which might coincide with the reappearance of the banners.

I'd need to check whether the symptoms are the same, but it might well just be
a regression of bug #3235, as Ryan suggested in comment #2.
Comment 6 Dave Neary maemo.org 2010-03-10 20:17:30 UTC 
Patch committed to maemo2midgard svn - synchronisation needed with
/usr/share/mediawiki/includes/User.php on wiki.maemo.org:
https://garage.maemo.org/plugins/scmsvn/viewcvs.php?view=revision&root=maemo2midgard&revision=1630

Awaiting sync - when Wiki is synced the bug can be closed as fixed.

Dave.
Comment 7 Ferenc Szekely maemo.org 2010-03-22 17:03:25 UTC 
Sync done. We use the svn checkout now for mediawiki includes. Thanks Dave for
the fix.
First Last Prev Next    No search results available