Bug 8731 - Memory leaks in widget HildonAnimationActor
: Memory leaks in widget HildonAnimationActor
Status: VERIFIED FIXED
Product: Desktop platform
hildon-widgets
: 5.0/(2.2009.51-1)
: All Maemo
: Unspecified normal (vote)
: 5.0/(10.2010.19-1)
Assigned To: Alberto Garcia Gonzalez
: hildon-libs-bugs
:
:
:
:
  Show dependency tree
 
Reported: 2010-01-31 23:43 UTC by Vlad Vasiliev
Modified: 2010-04-14 00:57 UTC (History)
2 users (show)

See Also:


Attachments
Source of test (2.07 KB, text/x-csrc)
2010-01-31 23:44 UTC, Vlad Vasiliev
Details
Valgrind's log (3.50 KB, application/octet-stream)
2010-01-31 23:45 UTC, Vlad Vasiliev
Details


Note

You need to log in before you can comment on or make changes to this bug.


Description Vlad Vasiliev (reporter) 2010-01-31 23:43:36 UTC
SOFTWARE VERSION:

SDK FREMANTLE_X86 
libhildon-2.2.3

EXACT STEPS LEADING TO PROBLEM: 
I downloaded source of libhildon-2.2.3
apt-get source libhildon
Took simple test from hildon-animation-actor.c and modified it  see attach
(test_hildon_animation.c)

Compiled it:
gcc -g -o test  -I/usr/include -I/usr/X11R6/include `pkg-config --cflags  
hildon-1 `  `pkg-config --libs  hildon-1 ` test_hildon_animation.c
Run under valgring:
cp test /usr/bin/test && run-standalone.sh run-with-memcheck  /usr/bin/test
And I saw memory leaks in log file (see attach memcheck-test-1873.log)



EXPECTED OUTCOME:
Widget without memory leaks

ACTUAL OUTCOME:
Widget with memory leaks

REPRODUCIBILITY:


EXTRA SOFTWARE INSTALLED:

OTHER COMMENTS:

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.9.0.7)
Gecko/2009032803 Iceweasel/3.0.6 (Debian-3.0.6-1)
Comment 1 Vlad Vasiliev (reporter) 2010-01-31 23:44:31 UTC
Created an attachment (id=2176) [details]
Source of test
Comment 2 Vlad Vasiliev (reporter) 2010-01-31 23:45:57 UTC
Created an attachment (id=2177) [details]
Valgrind's log
Comment 3 Vlad Vasiliev (reporter) 2010-01-31 23:53:18 UTC
I have forgotten to tell that you should press on the button in a window for 
destroying of Acter for checking memory leaks.
Comment 4 Alberto Garcia Gonzalez 2010-02-01 14:12:57 UTC
Thanks for spotting this

diff --git a/hildon/hildon-animation-actor.c b/hildon/hildon-animation-actor.c
index beaf8f5..6283835 100644
--- a/hildon/hildon-animation-actor.c
+++ b/hildon/hildon-animation-actor.c
@@ -291,6 +291,7 @@ hildon_animation_actor_finalize                (GObject
*object)

        g_object_unref (priv->parent);
     }
+    G_OBJECT_CLASS (hildon_animation_actor_parent_class)->finalize (object);
 }

 static void
Comment 6 Andre Klapper maemo.org 2010-03-15 20:54:25 UTC
Setting explicit PR1.2 milestone (so it's clearer in which public release the
fix will be available to users).

Sorry for the bugmail noise (you can filter on this message).