Bug 823 – support for Hildon specific hacks to GTK+ should be conditional

Bug 823 - support for Hildon specific hacks to GTK+ should be conditional


Summary:	support for Hildon specific hacks to GTK+ should be conditional

Status:	CLOSED FIXED

Product:	Desktop platform
Component:	hildon-widgets
Version:	unspecified
Platform:	All Maemo

Importance:	Medium normal (vote)
Target Milestone:	---
Assigned To:	Michael Kostrzewa
QA Contact:	HAF QA mailing list

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2006-11-01 17:12 UTC by Johan Bilien
Modified:	2008-12-06 13:19 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Compiles with upstream GTK (9.91 KB, patch) 2006-11-01 17:13 UTC, Johan Bilien	Details
more recent version (25.38 KB, patch) 2007-03-02 09:55 UTC, Johan Bilien	Details
Define -DMAEMO_CHANGES conditionally (1.53 KB, patch) 2007-08-31 11:03 UTC, Mohammad Anwari	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Johan Bilien (reporter) nokia

2006-11-01 17:12:21 UTC

The attached patch makes the support for Hildon-specific GTK+ changes
conditional at least at compilation time. Checks are made at configure time.

Please double-check amd fix my autoconf-fu :)

Comment 1 Johan Bilien (reporter) nokia

2006-11-01 17:13:25 UTC

Created an attachment (id=125) [details]
Compiles with upstream GTK

Please consider reviewing and applying to trunk.

Comment 2 Johan Bilien (reporter) nokia

2006-11-01 17:14:07 UTC

Note that bug# 822 needs to be fixed too in order to actually compile with a
recent gcc.

Comment 3 Michael Kostrzewa nokia

2007-02-07 14:00:03 UTC

Tommi, how this relates to MAEMO_CHANGES?

Comment 4 Tommi Komulainen nokia

2007-02-07 14:14:11 UTC

If you do not define MAEMO_CHANGES the added functions, enums, function
pointers
will not be available and if you try to use them the compilation will fail. It
does not catch property access, though (they probably should be encapsulated in
functions)

What Johan's patch does is to remove any attempts to use our extended
functionality so that hildon can be compiled against stock gtk (or maemo gtk
without MAEMO_CHANGES)

I think we should have --enable-gtk-extensions[=yes/no/auto] configure flag
(default=auto) which would determine whether MAEMO_CHANGES gets defined (while
building as well as in the pkgconfig file) and our gtk extensions are even
attempted to be used.

Did that make any sense?


btw, GDK_WINDOW_TYPE_HINT_MESSAGE should be replaced with
GDK_WINDOW_TYPE_HINT_NOTIFICATION as soon as we have matchbox which supports
the
hint. That would be one patch/conditional less.

Comment 5 Johan Bilien (reporter) nokia

2007-03-02 09:55:58 UTC

Created an attachment (id=192) [details]
more recent version

Attaching last version of the patch i used for the archive

Comment 6 Luc Pionchon nokia

2007-03-02 16:12:02 UTC

(reassigned to Michael)

Comment 7 Mohammad Anwari maemo.org

2007-08-31 11:03:24 UTC

Created an attachment (id=533) [details]
Define -DMAEMO_CHANGES conditionally

This patch only define MAEMO_CHANGES if MAEMO_GTK is used.

Comment 8 Mohammad Anwari maemo.org

2007-08-31 11:05:38 UTC

(In reply to comment #5)
> Created an attachment (id=192) [details] [details]
> more recent version

hildon-1 already have #ifdef MAEMO_GTK.

My patch defines the MAEMO_CHANGES only if MAEMO GTK is used. Currently
hildon-1 in Ubuntu/Gutsy also defines the MAEMO_CHANGES in the CFLAGS and
pkgconfig and I think that should be turned off there.

Comment 9 Xan López nokia

2007-10-10 16:45:17 UTC

I committed this to trunk now, thanks for the patch!

Comment 10 Andre Klapper maemo.org

2008-12-06 13:19:08 UTC

(changing Version from "sardine" to "unspecified" for consistency with other
products)