Bug 7014 – ash saves only 15 lines of history

Bug 7014 - (int-206477) ash saves only 15 lines of history

(int-206477)
Summary:	ash saves only 15 lines of history

Status:	RESOLVED FIXED

Product:	Core
Component:	Busybox
Version:	5.0/(1.2009.42-11)
Platform:	All Maemo

Importance:	Low enhancement with 12 votes (vote)
Target Milestone:	Harmattan
Assigned To:	Turo Janka
QA Contact:	busybox-bugs

URL:
Keywords:	community-diablo, community-fremantle...

Depends on:
Blocks:
	Show dependency tree

Reported:	2009-12-16 02:40 UTC by Josh Triplett
Modified:	2011-05-05 23:41 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Josh Triplett (reporter) 2009-12-16 02:40:46 UTC

SOFTWARE VERSION:
(Settings > General > About product)
1.2009.42-11.002

EXACT STEPS LEADING TO PROBLEM: 
(Explain in detail what you do (e.g. tap on OK) and what you see (e.g. message
Connection Failed appears))
1. Open an X terminal.
2. Type more than 15 different commands.
3. Type "exit", or press ctrl-d, or use the workaround from bug 5317 and then
just close the X terminal.
4. Open an X terminal.
5. Press up repeatedly to recall commands from history.  Or, type "wc -l
.ash_history" to see the number of lines in .ash_history .

EXPECTED OUTCOME:
More than 15 commands saved.

ACTUAL OUTCOME:
Only 15 commands saved.

REPRODUCIBILITY:
always

OTHER COMMENTS:

As far as I know, changing this may require recompiling busybox ash with a new
setting.  I'd propose increasing this to a reasonable number, preferably a few
thousand or so.  Even a few thousand short text lines would take only a handful
of kB, hardly a dent in the /home partition.

Even better if you can compile busybox ash to observe HISTFILESIZE or similar,
to allow setting this at runtime.

Comment 1 Lucas Maneos 2009-12-16 03:08:26 UTC

(In reply to comment #0)
> As far as I know, changing this may require recompiling busybox ash with a new
> setting.

Yes, it's a compile-time option (CONFIG_FEATURE_EDITING_HISTORY).

> I'd propose increasing this to a reasonable number, preferably a few
> thousand or so.  Even a few thousand short text lines would take only a 
> handful of kB, hardly a dent in the /home partition.

It also affects the root fs (user root) and RAM usage, but a few hundred
entries at least shouldn't have much impact.

Comment 2 Andre Klapper maemo.org

2010-11-22 18:45:03 UTC

(Still valid in Harmattan currently.)

Comment 3 Andre Klapper maemo.org

2011-05-05 17:28:13 UTC

Upstream patch at
http://git.busybox.net/busybox/commit/?id=2c4de5b045a79db73052d5b865474a00c9a87e99
was applied to Nokia's internal Harmattan (the software version after Maemo5)
builds and verified.
According to Nokia this unfortunately is a WONTFIX for Maemo5, however this
could get included by the CSSU updates (=> requires bug report against "Maemo 5
Community Updates" product here).

Comment 4 Josh Triplett (reporter) 2011-05-05 23:41:46 UTC

(In reply to comment #3)
> Upstream patch at
> http://git.busybox.net/busybox/commit/?id=2c4de5b045a79db73052d5b865474a00c9a87e99
> was applied to Nokia's internal Harmattan (the software version after Maemo5)
> builds and verified.
> According to Nokia this unfortunately is a WONTFIX for Maemo5, however this
> could get included by the CSSU updates (=> requires bug report against "Maemo 5
> Community Updates" product here).

Filed as bug 12211.