Bug 5347 – address book cannot import vcards from benq/siemens phones properly

Bug 5347 - (int-132818) address book cannot import vcards from benq/siemens phones properly

(int-132818)
Summary:	address book cannot import vcards from benq/siemens phones properly

Status:	RESOLVED FIXED

Product:	Contacts
Component:	General
Version:	5.0/(1.2009.41-10)
Platform:	N900 Linux

Importance:	Low normal (vote)
Target Milestone:	5.0/(2.2009.51-1)
Assigned To:	unassigned
QA Contact:	contacts-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2009-10-12 22:56 UTC by Lennart Poettering
Modified:	2010-01-14 12:27 UTC (History)
CC List:	4 users (show)

See Also:

Attachments
incompatible vcard (138 bytes, text/plain) 2009-10-12 22:57 UTC, Lennart Poettering	Details
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Lennart Poettering (reporter) 2009-10-12 22:56:34 UTC

N900 Maemo 5, 1.2009.41-10

Adressbook fails to import vcards from BenQ/Siemens mobile phone. Drops data
from it, chokes on Umlauts.

I am attaching a vcard from that phone. I replaced the phone number/surname
carefully and made sure that the file otherwise continued to use the
charsets/yadda yadda it used before.

Comment 1 Lennart Poettering (reporter) 2009-10-12 22:57:28 UTC

Created an attachment (id=1405) [details]
incompatible vcard

Comment 2 Lucas Maneos 2009-10-13 02:15:25 UTC

That N property looks invalid.  According to the 2.1 spec
(<http://www.imc.org/pdi/vcard-21.txt>):

> The default character set is ASCII. The default character set can be overridden > for an individual property value by using the "CHARSET" property parameter.

Comment 3 Lennart Poettering (reporter) 2009-10-13 02:23:44 UTC

(In reply to comment #2)
> That N property looks invalid.  According to the 2.1 spec
> (<http://www.imc.org/pdi/vcard-21.txt>):
> 
> > The default character set is ASCII. The default character set can be overridden > for an individual property value by using the "CHARSET" property parameter.
> 

Yes, the vcf seems to be in ISO-8859-1 or so. Maybe instead of insisting that
the vcf files be correct the importing should be smart and auto-detect the
encoding or using iso-8859-1 as fallback. And even if that should not work out
it would still be better if the import would replace the invalid char by some
escape code instead of just dropping the entire entry.

Comment 4 Mathias Hasselmann maemo.org

2009-10-13 02:29:34 UTC

(In reply to comment #2)
> That N property looks invalid.  According to the 2.1 spec
> (<http://www.imc.org/pdi/vcard-21.txt>):
> 
> > The default character set is ASCII. The default character set can be overridden > for an individual property value by using the "CHARSET" property parameter.
> 

Like Lennart said: In IOP there is no price given for interpreting specs most
strictly. The price is given for reading as many real world cards as possible.
Siemens/BENQ sold many of those phones, and their vCard implementation is
broken, but users will blame us for getting it wrong.

Comment 5 Andre Klapper maemo.org

2009-11-20 12:54:49 UTC

This has been fixed in package
evolution-data-server 1.4.2.1-20091116+0m5
which is part of the internal build version
2.2009.47-17
(Note that 2009 is the year and the number after is the week.)

Any public update released with or after this build version will include the
fix.
Please verify that the new version fixes the bug by marking this bug report as
VERIFIED after the public update has been released and if you have some time.

Comment 6 lionel 2009-12-21 18:27:08 UTC

FYI, VCF files from PalmOS devices (in this case a Treo 600; VCF export from
on-PC Palm Desktop application version 4.1) suffer from the same flaw (encoded
in Latin-1 AKA ISO 8859-1) and that same fix should work for them, too.

Comment 7 Andre Klapper maemo.org

2010-01-14 12:27:58 UTC

The problem reported here should be fixed in the update released today for
public: The Maemo5 update version 2.2009.51-1 (also called "PR1.1" sometimes).
Please leave a comment if the problem is not fixed for you in this update
version.