maemo.org Bugzilla – Bug 5266
Remove unneeded modest_osso_load_state () calls
Last modified: 2010-03-15 20:55:57 UTC
You need to log in before you can comment on or make changes to this bug.
modest_osso_load_state () is an empty function Patch following
Created an attachment (id=1393) [details] Remove unneeded modest_osso_load_state () calls
As long as you're cleaning this up, maybe also get rid of the modest_osso_save_state() calls and remove modest-osso-state-saving.{c,h}?
Created an attachment (id=1394) [details] Remove unneeded modest_osso_load_state () calls.v2 I've removed modest_osso_save_state too because we can call modest_window_mgr_save_state_for_all_windows() directly
Created an attachment (id=1395) [details] Remove unneeded modest_osso_load_state () calls.v3 Also, removed references from Makefile.am files
Reviewing the patch
Committed in Modest master a3c0bc9841bbe205ebf7a0a65e70603a0281b0c5 Note that I removed the osso-autosave callbacks as they were not used in hildon2 as well.
I must admit that I don't know if the fix is already included in today's 2.2009.51-1 update release or not. Checking and reporting back is welcome!
(In reply to comment #7) > I must admit that I don't know if the fix is already included in today's > 2.2009.51-1 update release or not. Checking and reporting back is welcome! Andre, I verified that modest_osso_load_state() function is still present in 3.0, 3.1 and 3.2 branches, but it's removed from master branch Don't know what is the version used in actual maemo platform
Okay, so this is PR1.2 stuff. Thanks for checking.
Setting explicit PR1.2 milestone (so it's clearer in which public release the fix will be available to users). Sorry for the bugmail noise (you can filter on this message).