Bug 5153 – libsdl: After call to SDL_WM_SetIcon, SDL windows are not focusable

Bug 5153 - (int-139749) libsdl: After call to SDL_WM_SetIcon, SDL windows are not focusable

(int-139749)
Summary:	libsdl: After call to SDL_WM_SetIcon, SDL windows are not focusable

Status:	NEW

Product:	Desktop platform
Component:	general
Version:	5.0/(3.2010.02-8)
Platform:	ARM Maemo

Importance:	Low minor with 8 votes (vote)
Target Milestone:	5.0+
Assigned To:	unassigned
QA Contact:	HAF QA mailing list

URL:	http://bugzilla.libsdl.org/show_bug.c...
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree

Reported:	2009-09-18 01:03 UTC by Javier S. Pedro
Modified:	2010-09-08 19:08 UTC (History)
CC List:	4 users (show)

See Also:

Attachments
patch for setting the input hint correctly (653 bytes, patch) 2010-03-16 22:45 UTC, Javier S. Pedro	Details
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Javier S. Pedro (reporter) 2009-09-18 01:03:00 UTC

SOFTWARE VERSION: Fremantle Beta 2 SDK (and device)

STEPS TO REPRODUCE THE PROBLEM:
1. Run DOSBox (or any other SDL app with a SDL_WM_SetIcon call for the matter).

EXPECTED OUTCOME:
You can write in the command.com prompt.

ACTUAL OUTCOME:
You cannot.

REPRODUCIBILITY: always.

OTHER COMMENTS:
This is confirmed by upstream: http://bugzilla.libsdl.org/show_bug.cgi?id=586 ,
but the bug is much more noticeable in Fremantle where the window manager seems
to actually care about WM_HINTS.

Also see: http://talk.maemo.org/showthread.php?t=31696 and
http://mxr.maemo.org/diablo/source/libsdl1.2-1.2.8/src/video/x11/SDL_x11wm.c#232
.

There is a (seemingly) working workaround for the bug, which is to remove the
call to SDL_WM_SetIcon. Since icons are pulled from .desktop files, this should
present no problems. 

The reason I'm filling this is that it would be interesting to backport
whatever fix is produced back to the Fremantle libsdl before it's too late and
another Maemo SDL weirdness has to be added to the wiki page :) .

Comment 1 Mikko Vartiainen 2009-10-13 12:56:48 UTC

I can confirm this bug. In Crimson Fields 0.5.3-1maemo3 all keyboard events go
to underlying window (for example xterm or hildondesktop), mouse events do
work.

Comment 2 Kaj-Michael Lang 2009-10-13 15:17:15 UTC

I can confirm this too in Maelstrom on the N900. 
Works fine in N810, on the N900 it's unusable.

Comment 3 Javier S. Pedro (reporter) 2009-10-13 17:06:27 UTC

Fixed in upstream SVN now, see http://bugzilla.libsdl.org/show_bug.cgi?id=586
for patch. Backport?

(Also note DOSBox had the SDL_WM_SetIcon removed and thus is no longer a
testcase).

Comment 4 Kaj-Michael Lang 2009-11-17 11:42:27 UTC

Any chance of getting a SDL update to fix this?

Comment 5 Javier S. Pedro (reporter) 2010-03-16 22:45:35 UTC

Created an attachment (id=2483) [details]
patch for setting the input hint correctly

I am attaching the upstream patch to this bugreport. Applies cleanly to
libsdl1.2-1.2.13 .

Also note that the bug is fixed in upstream SDL 1.2.14 .