maemo.org Bugzilla – Bug 4834
Remove deprecated GTK+ symbols
Last modified: 2010-03-15 20:55:45 UTC
You need to log in before you can comment on or make changes to this bug.
Modest uses deprecated GTK+ symbols that will be removed for GTK+ 3. See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B
Created an attachment (id=1279) [details] Remove deprecated GTK+ symbols
Thank you very much for the patch Javier! Fixed in Modest master 269572150f690858f71dc3a626a84c9a5fec98bb Keep contributing!
Hello Sergio, I've reopened this bug because there are still deprecated gtk+ symbols. I'll send more patches soon ;) Regards
Created an attachment (id=1284) [details] Remove deprecated GTK+ symbols. part2
Is this the final patch ?
Created an attachment (id=1285) [details] Remove deprecated GTK+ symbols. part2.v2 The previous patch was one line wrong.Here a new one with one more deprecation symbol fixed
There are no current plans to remove the code for gtk version < 2.12.
A couple of comments about this patch. * There is some code about refiltering that has nothing to do with deprecated symbols. * You have to surround the g_object_ref_sink calls that you're adding with the conditional code that checks the Gtk+ version * Now that you are changing the patch (hopefully :)), please do also recreate it with the current master that does not include gnome/ and maemo/ directories. Thx!
Created an attachment (id=1533) [details] Remove deprecated GTK+ symbols_v3 Hey Sergio, here a new patch as you requested. There are still 2 recently deprecated symbols, gtk_action_block_activate_from() and gtk_action_unblock_activate_from(), but I'm not very sure how substitute them Regards
Applied the patch in modest master Fixed in master 07b4b24bacfc227ccd63df56a0ee7734ececd4fd Thx Javier for your patch!!!
Setting explicit PR1.2 milestone (so it's clearer in which public release the fix will be available to users). Sorry for the bugmail noise (you can filter on this message).