Bug 4673 – hildon_entry_set_placeholder() should be in GtkEntry.

Bug 4673 - (int-122395) hildon_entry_set_placeholder() should be in GtkEntry.

(int-122395)
Summary:	hildon_entry_set_placeholder() should be in GtkEntry.

Status:	RESOLVED FIXED

Product:	Desktop platform
Component:	gtk
Version:	5.0-beta
Platform:	All Linux

Importance:	Medium normal (vote)
Target Milestone:	5.0 (1.2009.41-10)
Assigned To:	unassigned
QA Contact:	gtk-bugs

URL:	http://bugzilla.gnome.org/show_bug.cg...
Keywords:	upstream

Depends on:
Blocks:	4740 4778
	Show dependency tree

Reported:	2009-06-12 10:45 UTC by Murray Cumming
Modified:	2009-08-21 12:28 UTC (History)
CC List:	6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Murray Cumming (reporter) 2009-06-12 10:45:15 UTC

HildonEntry seems to just add a placeholder feature to GtkEntry. That should be
added upstream to GTK+, probably as a property:
http://maemo.org/api_refs/5.0/beta/hildon/HildonEntry.html#hildon-entry-set-placeholder

As well as making porting easier, by avoiding the need to ifdef a choice of
GtkEntry or HildonEntry, this would make gtk_entry_get/set_text() ignore the
placeholder text.

Comment 1 Murray Cumming (reporter) 2009-06-12 11:08:44 UTC

Likewise for HildonTextView:
http://maemo.org/api_refs/5.0/beta/hildon/HildonTextView.html

Comment 2 Claudio Saavedra 2009-06-12 11:10:09 UTC

This is actually a GTK+ bug. We would drop the placeholder feature if this
could be added to GTK+.

I filed a bug upstream with an initial implementation (#566741) but it was
duplicated and the original bug (#440963) seems to be a source of disagreements
that won't be resolved anytime soon. An implementation in maemo-gtk would
probably be the way to go.

Comment 3 Murray Cumming (reporter) 2009-06-12 11:53:48 UTC

Well done. The links, for convenience:
http://bugzilla.gnome.org/show_bug.cgi?id=566741
marked as a duplicate of:
http://bugzilla.gnome.org/show_bug.cgi?id=440963

I replied there, trying to move it along. It would have been nice if the Hildon
developers had done that. It seems possible to get it accepted upstream.

Comment 4 Michael Natterer 2009-07-31 12:05:45 UTC

Placeholder text API has been added to GtkEntry and GtkTextView in
Maemo-GTK. Resolving as FIXED.

Comment 5 Alberto Garcia Gonzalez 2009-08-04 20:24:03 UTC

Apart from the changes in Maemo-gtk, the changes to Hildon are here:

https://git.maemo.org/projects/hildon/gitweb?p=hildon;a=commitdiff;h=612b3ad6022252538dcdafe78f63a36a7d1b9335

Comment 6 Andre Klapper maemo.org

2009-08-21 12:23:32 UTC

...and this is also internally integrated into builds now.

Comment 7 Murray Cumming (reporter) 2009-08-21 12:28:11 UTC

Great. 

So what's the (documented) purpose of HildonEntry and HildonTextView now,
rather than their GTK+ equivalents?