maemo.org Bugzilla – Bug 3439
Connects to Audio but does not play sound when successfully installing package
Last modified: 2010-02-01 14:46:14 UTC
You need to log in before you can comment on or make changes to this bug.
SOFTWARE VERSION: 4.2008.23-14 STEPS TO REPRODUCE THE PROBLEM: 1. Open Application manager. 2. Install a package. 3. Listen to the error sound play when the package installs successfully. EXPECTED OUTCOME: Either no sound plays or a sound plays that isn't the error sound. ACTUAL OUTCOME: The error sound plays on a successful outcome. REPRODUCIBILITY: Always OTHER COMMENTS: I've been listening to this sound play after every successful install for more than 2 years and it's _still_ jarring to me. User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US) AppleWebKit/525.18 (KHTML, like Gecko, Safari/525.20) OmniWeb/v622.1.0.102133
I confirm this. when you install a package success. you will hear a ui-information-note.wav sound. when you install a package fail. you will also hear a ui-information-note.wav sound. The sound files are in /usr/share/sounds. you can entry this directory to hear. I will give two patch. one of them is used to patch the libhildon. The other is used to patch the hildon-application-manager. I only changed the sound when you install a package success . for instance, when you install,uninstall or update package success, you will hear a ui-default_beep sound.
Created an attachment (id=909) [details] modify the hildon-note.c and hildon-note.h This patch is used to patch the libhildon2.0.4.
Created an attachment (id=910) [details] modify util.cc util.h operations.cc This patch is used to patch the hildon-application-manager2.1.16
Jianjun: In general (please tell this to everybody at Plenware), please clean up your patches. Don't include clutter lines, remove your debug comments, don't change indention, provide a ChangeLog entry, respect the code style (e.g. where to set a whitespace and where not - check your function calls and the brackets). > - annoy_user (msg, cont, data); > + annoy_user (msg, cont, data); /************************/ I don't want to see such lines in any of the patches attached here. Please provide an updated, clean patch.
Jianjun Yu: Can you come up with a clean patch?
(Note to myself: This does not seem to be defined in any Spec. Surprise! ;-)
(In reply to comment #5) > Jianjun Yu: Can you come up with a clean patch? > Sorry for late, I will update the patch. Thanks for you point out my mistake.
Created an attachment (id=1055) [details] update the patch to modify util.cc util.h operations.cc update the patch to modify util.cc util.h operations.cc.
(In reply to comment #8) > Created an attachment (id=1055) [details] [details] > update the patch to modify util.cc util.h operations.cc Thanks, but this still does not respect the code style (e.g. where to set a whitespace and where not): E.g. noise like this: - dialog = hildon_note_new_information (NULL, text); + dialog = hildon_note_new_information(NULL, text); Or e.g. - annoy_user (_("ai_ni_all_installed"), ip_end, c); + annoy_user_success(_("ai_ni_all_installed"), ip_end, c); Please respect the code style by adding a whitespace in between function name and bracket, like everywhere else in the code.
Created an attachment (id=1058) [details] modify the code style of the last patch modify the code style of the last patch
Thanks! That latest patch is quite perfect! :)
Anybody willing to give Fremantle a try here? (Hmm, if the SDK ships sounds. Probably not.)
I've tried to reproduce this in Fremantle, not sure about my results though: There is a sound after successfully installing an application. Now I tried to install gFTP (which is currently not possible because of bug 4754). Hence I get an error about gFTP breaking the policy, but no sound is played at all in this case. Either that sound is still missing; or this is expected behaviour and hence kind of "fixed".
Trying out with Fremantle. No sound when banner of installation successful appears, but (listening with headset) the audio seems to be connecting for that period. Smells like a minor bug, yes.
Marking patches of interest to Diablo (Maemo4) community updates, please excuse the noise.
"The proposed patch implies a modification in hildon. Please open a bug to hildon-widgets first. Marking as WONTFIX for App Manager" (because this is currently not planned to be supported/changed).