Bug 3439 - (int-94337/int-139302) Connects to Audio but does not play sound when successfully installing package
(int-94337/int-139302)
: Connects to Audio but does not play sound when successfully installing package
Status: RESOLVED WONTFIX
Product: Settings and Maintenance
Application manager
: 5.0-beta2
: All All
: Low minor with 1 vote (vote)
: ---
Assigned To: unassigned
: application-manager-bugs
:
: community-diablo, patch
:
:
  Show dependency tree
 
Reported: 2008-07-11 20:22 UTC by Ryan Abel
Modified: 2010-02-01 14:46 UTC (History)
4 users (show)

See Also:


Attachments
modify the hildon-note.c and hildon-note.h (4.19 KB, patch)
2008-08-26 12:42 UTC, Jianjun Yu
Details
modify util.cc util.h operations.cc (2.90 KB, patch)
2008-08-26 12:46 UTC, Jianjun Yu
Details
update the patch to modify util.cc util.h operations.cc (2.73 KB, patch)
2008-11-28 06:51 UTC, Jianjun Yu
Details
modify the code style of the last patch (2.57 KB, patch)
2008-12-03 04:20 UTC, Jianjun Yu
Details


Note

You need to log in before you can comment on or make changes to this bug.


Description Ryan Abel (reporter) maemo.org 2008-07-11 20:22:56 UTC
SOFTWARE VERSION:
4.2008.23-14

STEPS TO REPRODUCE THE PROBLEM:

1. Open Application manager.
2. Install a package.
3. Listen to the error sound play when the package installs successfully.

EXPECTED OUTCOME:
Either no sound plays or a sound plays that isn't the error sound.

ACTUAL OUTCOME:
The error sound plays on a successful outcome.

REPRODUCIBILITY:
Always

OTHER COMMENTS:
I've been listening to this sound play after every successful install for more
than 2 years and it's _still_ jarring to me.

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US)
AppleWebKit/525.18 (KHTML, like Gecko, Safari/525.20) OmniWeb/v622.1.0.102133
Comment 1 Jianjun Yu 2008-08-26 12:39:08 UTC
I confirm this. when you install a package success. you will hear a
ui-information-note.wav sound. when you install a package fail. you will also
hear a ui-information-note.wav sound.

The sound files are in /usr/share/sounds. you can entry this directory to hear.

I will give two patch. one of them is used to patch the libhildon. The other is
used to patch the hildon-application-manager.

I only changed the sound when you install a package success . for instance,
when you install,uninstall or update package success, you will hear a
ui-default_beep sound.
Comment 2 Jianjun Yu 2008-08-26 12:42:47 UTC
Created an attachment (id=909) [details]
modify the hildon-note.c and hildon-note.h

This patch is used to patch the libhildon2.0.4.
Comment 3 Jianjun Yu 2008-08-26 12:46:16 UTC
Created an attachment (id=910) [details]
modify util.cc util.h operations.cc

This patch is used to patch the hildon-application-manager2.1.16
Comment 4 Andre Klapper maemo.org 2008-10-22 14:08:10 UTC
Jianjun:
In general (please tell this to everybody at Plenware), please clean up your
patches. Don't include clutter lines, remove your debug comments, don't change
indention, provide a ChangeLog entry, respect the code style (e.g. where to set
a whitespace and where not - check your function calls and the brackets).

> -  annoy_user (msg, cont, data);
> +  annoy_user (msg, cont, data); /************************/

I don't want to see such lines in any of the patches attached here.

Please provide an updated, clean patch.
Comment 5 Andre Klapper maemo.org 2008-11-27 12:48:41 UTC
Jianjun Yu: Can you come up with a clean patch?
Comment 6 Andre Klapper maemo.org 2008-11-27 12:56:29 UTC
(Note to myself: This does not seem to be defined in any Spec. Surprise! ;-)
Comment 7 Jianjun Yu 2008-11-28 06:48:18 UTC
(In reply to comment #5)
> Jianjun Yu: Can you come up with a clean patch?
> 

Sorry for late, I will update the patch. Thanks for you point out my mistake.
Comment 8 Jianjun Yu 2008-11-28 06:51:32 UTC
Created an attachment (id=1055) [details]
update the patch to modify util.cc util.h operations.cc

update the patch to modify util.cc util.h operations.cc.
Comment 9 Andre Klapper maemo.org 2008-12-02 17:11:44 UTC
(In reply to comment #8)
> Created an attachment (id=1055) [details] [details]
> update the patch to modify util.cc util.h operations.cc

Thanks, but this still does not respect the code style (e.g. where to set
a whitespace and where not):

E.g. noise like this:
-  dialog = hildon_note_new_information (NULL, text);
+  dialog = hildon_note_new_information(NULL, text);

Or e.g.
-      annoy_user (_("ai_ni_all_installed"), ip_end, c);
+      annoy_user_success(_("ai_ni_all_installed"), ip_end, c);

Please respect the code style by adding a whitespace in between function name
and bracket, like everywhere else in the code.
Comment 10 Jianjun Yu 2008-12-03 04:20:42 UTC
Created an attachment (id=1058) [details]
modify the code style of the last patch

modify the code style of the last patch
Comment 11 Andre Klapper maemo.org 2008-12-03 05:37:07 UTC
Thanks! That latest patch is quite perfect! :)
Comment 12 Andre Klapper maemo.org 2009-04-23 15:41:07 UTC
Anybody willing to give Fremantle a try here?
(Hmm, if the SDK ships sounds. Probably not.)
Comment 13 Andre Klapper maemo.org 2009-07-16 16:48:00 UTC
I've tried to reproduce this in Fremantle, not sure about my results though:
There is a sound after successfully installing an application.
Now I tried to install gFTP (which is currently not possible because of bug
4754). Hence I get an error about gFTP breaking the policy, but no sound is
played at all in this case.
Either that sound is still missing; or this is expected behaviour and hence
kind of "fixed".
Comment 14 Quim Gil nokia 2009-09-14 07:59:38 UTC
Trying out with Fremantle. No sound when banner of installation successful
appears, but (listening with headset) the audio seems to be connecting for that
period.

Smells like a minor bug, yes.
Comment 15 Lucas Maneos 2009-10-22 07:57:23 UTC
Marking patches of interest to Diablo (Maemo4) community updates, please excuse
the noise.
Comment 16 Andre Klapper maemo.org 2010-02-01 14:46:14 UTC
"The proposed patch implies a modification in hildon. Please open a bug to
hildon-widgets first. Marking as WONTFIX for App Manager" (because this is
currently not planned to be supported/changed).