Bug 2376 – maemo-hello-app uses invalid icon header name in control

Bug 2376 - maemo-hello-app uses invalid icon header name in control


Summary:	maemo-hello-app uses invalid icon header name in control

Status:	CLOSED INVALID

Product:	Development platform
Component:	SDK
Version:	4.0
Platform:	All Linux

Importance:	Low normal (vote)
Target Milestone:	---
Assigned To:	Soumya
QA Contact:	sdk-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2007-11-24 15:58 UTC by Aleksandr Koltsoff
Modified:	2008-08-20 07:34 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Aleksandr Koltsoff (reporter) 2007-11-24 15:58:58 UTC

STEPS TO REPRODUCE THE PROBLEM:

Grep for "Maemo-Icon-26" in repository Packages.gz (
http://repository.maemo.org/dists/chinook/free/binary-i386/Packages.gz )

hello-world-app defines 'Maemo-Icon-26' instead of using the "XB- "-prefix for
non-Debian control fields as it should. This leads for the icon leaking into
the packages list.

hello-world-app is the only package in that packages-list to exhibit this.

EXPECTED OUTCOME:

The icon would be not part of the repo packages list.

ACTUAL OUTCOME:

It is.

REPRODUCIBILITY:
(always/sometimes/once)

Always (hello-world-app version 0.7)

EXTRA SOFTWARE INSTALLED:

OTHER COMMENTS:

Comment 1 Aleksandr Koltsoff (reporter) 2007-11-26 03:35:24 UTC

Actually the bug seems to be somewhere else, as the source for the control file
is prefixed with XB- correctly:

http://timeless.justdave.net/mxr-test/chinook/source/hello-world-app-0.7/debian/control

Maybe your public repo publishing scripts munge the XB- prefix out of the
headers before generating the Packages file?

This seems to be the case when looking at the Packages-file in the extras
repository (free & non-free only have that one example of the icon used):

http://repository.maemo.org/extras/dists/chinook/free/binary-i386/Packages

If stripping the XB- header from the header name is intentional and required by
the application manager to display the icons, that is fine. However, this
breaks Debian policy of having extension headers start with XB- and also this
goes against the Debian packaging HOWTO for 4.0.

Also, it's slightly illogical to use XB-Maemo-Icon-26 in the source control
file, and seeing the same header without the XB- in the repo Packages file.

Comment 2 Terje Bergström nokia

2007-11-26 08:56:28 UTC

Ferenc, you might be the best to comment this. Our control does contain
XB-Maemo-Icon-26 field, but they end up as showing Maemo-Icon-26 in Packages
file. Is this a feature or a bug?

Comment 3 Janne Kataja 2008-04-02 12:48:27 UTC

(In reply to comment #0)
> hello-world-app defines 'Maemo-Icon-26' instead of using the "XB- "-prefix for
> non-Debian control fields as it should. This leads for the icon leaking into
> the packages list.

This is the expected behaviour. The fields prefixed with XB in source package
debian/control will be added in binary package with the prefix XB removed.
See Debian Policy Manual, section 5.7. 
http://www.debian.org/doc/debian-policy/ch-controlfields.html#s5.7

Also, see "How to make a package for the Hildon Application Manager" in "Hildon
Application Manager" document:
http://hildon-app-mgr.garage.maemo.org/packaging.html

> hello-world-app is the only package in that packages-list to exhibit this.

Other packages in that repository did not contain icons for the application
manager.

(In reply to comment #2)
> Our control does contain
> XB-Maemo-Icon-26 field, but they end up as showing Maemo-Icon-26 in Packages
> file. Is this a feature or a bug?

The prefix XB- is there to preserve namespace.

Comment 4 Aleksandr Koltsoff (reporter) 2008-04-02 15:13:51 UTC

Seems that the packaging howto now also includes ref to polman 5.7, so that
clears the confusion.