Bug 1839 - tap and hold on links sometimes doesn't trigger animation / context menu
: tap and hold on links sometimes doesn't trigger animation / context menu
Status: RESOLVED WORKSFORME
Product: Browser
MicroB engine
: 4.1.3 (5.2008.43-7)
: All All
: Low normal with 2 votes (vote)
: 5.0 (1.2009.41-10)
Assigned To: unassigned
: microb-bugs
: http://www.internettablettalk.com/
:
:
:
  Show dependency tree
 
Reported: 2007-08-16 14:05 UTC by Frantisek Dufka
Modified: 2009-07-15 15:25 UTC (History)
2 users (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Frantisek Dufka (reporter) maemo.org 2007-08-16 14:05:43 UTC
Right click in maemo is done by holding stylus down, circle should appear and
after second or so right click action is done (mostly context menu)

In microb right clicking on links sometimes doesn't work and doesn't produce
context menu which makes it impossible to open link in new window. Workaround
seems to be to move pen out of link when holding it (to prevent clicking the
link) and try again. Second try (almost?) always work. Maybe the link first
needs to be focused (via first click) and then when already focused (with blue
rectangle around it) context menu works with next click.
Comment 1 timeless 2007-08-16 16:41:40 UTC
we tried chasing this code, you're welcome to join the hunt if you like.

one case i found that's interesting is double click, but i think it's the wrong
case.

http://timeless.justdave.net/mxr-test/garage/source/browser/mozilla/trunk/microb-eal/src/gmozillaengine.c

is most of the code.
The approach I had in hunting was to try to find the paths that start or stop
the animation handler.

stop_cursor_animation_handler seems like a reasonable function, and you can
find most of the relatives that way.

http://timeless.justdave.net/mxr-test/garage/source/browser/mozilla/trunk/microb-engine/microb-engine/debian/patches/gtkmozembed/gtkmozembed.diff#983

ends up being one of the fun code paths.

I think that the code path that's the most interesting is indeed the one that
triggers focus, because, if it's like the one that handles double click, maybe,
just maybe it stops the event.

The menu itself should trigger in:
dom_mouse_long_press_cb
http://timeless.justdave.net/mxr-test/garage/source/browser/mozilla/trunk/microb-eal/src/gmozillaengine.c#2480

this just kills it, but i think it's not the case I seek:
dom_mouse_dbl_click_cb 
http://timeless.justdave.net/mxr-test/garage/source/browser/mozilla/trunk/microb-eal/src/gmozillaengine.c#2517

The old start page seems to work as a testcase slightly.

it's definitely easiest to reproduce on a freshly loaded page, and it's best if
the link doesn't have focus.

when the animation does trigger, i can see it visibly jumping around, which to
me indicates that reproducing it should involve a sharp unmoving press and that
the reason the problem isn't always happening must relate to hearing a
move/second tap at different coords.

but we really don't get it.

a reduced testcase (if at all possible) should be very helpful. Note that this
code is a minefield, partly because of panning, and partly because of web page
heuristics. So probably the best testcase would be something like:

<script>function
handler(event){document.getElementById("handler").value+="\n"+event.type+Date.now();}</script><a
href="javascript:handler(event);return false;"><img width=500 height=200
src=about:logo></a><textarea id=output>

I don't have time to work on this atm, we spent a while just reading through
the code and picking out various other bugs along the way.
Comment 2 Frantisek Dufka (reporter) maemo.org 2007-11-27 01:14:43 UTC
FWIW just confirming that it still happens with OS2008 beta for N800.
Comment 3 Andre Klapper maemo.org 2008-11-25 19:02:38 UTC
timeless: Is there an internal ID for this, or is this even WONTFIX for Diablo?
I think I also see this issue in latest Diablo.
Comment 4 Andre Klapper maemo.org 2009-06-09 20:11:10 UTC
WONTFIX for Diablo (as Diablo will only receive critical updates if at all).
So far I haven't seen this issue in Fremantle yet.
Comment 5 Andre Klapper maemo.org 2009-06-19 18:48:15 UTC
*** Bug 2078 has been marked as a duplicate of this bug. ***
Comment 6 John Rudd 2009-06-19 19:00:23 UTC
Since 2078 is now listed as a duplicate of this bug, I thought I'd replicate my
reply over here.  I suggested that, for my specific case (wanting to easily
open links in a new window), just adding one or two new items to the Navigation
menu might be a useful work-around.  I was then asked:


> > Or, why not add the 2 items to the navigation menu?
> 
> Navigation currently has 7, I'm not sure what 2 you'd add (please specify, I
> don't mind talking/listening, it's the only way to get ideas somewhere people
> can see them).
> 
> Note that typically the context menu and the edit menu have some similarity,
> however, id on't know of any way to combine them that wouldn't upset everyone.
> 

The two items I would add to the navigation menu are:

Open in New Window
Open in New Tab (assuming tabs are enabled, I think they were in microb)
Comment 7 Andre Klapper maemo.org 2009-07-15 15:25:29 UTC
(In reply to comment #4)
> WONTFIX for Diablo (as Diablo will only receive critical updates if at all).
> So far I haven't seen this issue in Fremantle yet.

Tried to reproduce in Fremantle for the last five weeks but I haven't run into
this in the (not yet public) browser.
I consider this FIXED in Fremantle but as I don't know of an exact code fix I
prefer to call it WORKSFORME (very well).

As already written this is a WONTFIX for Diablo as Diablo is in maintenance
mode and Nokia will only provide bugfixes for critical issues if at all.
For your interest the Mer project aims to provide a community backport of
Fremantle for N8x0 devices. See http://wiki.maemo.org/Mer for more information.