Bug 1278 – Patch for xserver to get faster Xv video output performance (ARMv6 optimized YV12->YUV420 color format conversion)

Bug 1278 - (int-85053) Patch for xserver to get faster Xv video output performance (ARMv6 optimized YV12->YUV420 color format conversion)

(int-85053)
Summary:	Patch for xserver to get faster Xv video output performance (ARMv6 optimized ...

Status:	RESOLVED FIXED

Product:	Core
Component:	X Server
Version:	3.1
Platform:	All Maemo

Importance:	Medium enhancement with 8 votes (vote)
Target Milestone:	4.1
Assigned To:	Daniel Stone
QA Contact:	x-server-bugs

URL:
Keywords:	patch, performance

Depends on:
Blocks:
	Show dependency tree

Reported:	2007-05-01 20:35 UTC by Siarhei Siamashka
Modified:	2008-12-06 16:04 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Patch for faster Xv performance (12.98 KB, patch) 2007-05-01 20:37 UTC, Siarhei Siamashka	Details
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Siarhei Siamashka (reporter) 2007-05-01 20:35:51 UTC

Video output performance for Xv can be substantially improved, patch is
attached.
All the details can be found in a long thread in maemo-developers mailing list:
http://maemo.org/pipermail/maemo-developers/2007-April/009864.html

A short summary, performance of 'omapCopyPlanarDataYUV420' function gets
250%-300% improvement, some relevant benchmarks are posted here and in a few
followup posts:
http://maemo.org/pipermail/maemo-developers/2007-May/010039.html

Comment 1 Siarhei Siamashka (reporter) 2007-05-01 20:37:30 UTC

Created an attachment (id=405) [details]
Patch for faster Xv performance

Comment 2 Siarhei Siamashka (reporter) 2007-05-02 09:19:16 UTC

For this patch to be useful, https://maemo.org/bugzilla/show_bug.cgi?id=1281
needs to be fixed as well.

Comment 3 Siarhei Siamashka (reporter) 2007-05-05 08:55:52 UTC

Unofficial builds of xserver with this patch applied can be found here:
http://maemo.org/pipermail/maemo-developers/2007-May/010058.html

They don't have any known issues yet and really improve video performance quite
a lot:
http://www.internettablettalk.com/forums/showpost.php?p=47104&postcount=430
http://www.internettablettalk.com/forums/showpost.php?p=47105&postcount=431
http://www.internettablettalk.com/forums/showpost.php?p=47107&postcount=432

Comment 4 Daniel Stone nokia

2007-06-05 14:35:51 UTC

this has been scheduled for the release after next.

Comment 5 Siarhei Siamashka (reporter) 2007-08-17 21:36:21 UTC

Thanks, that's a great news. You can contact me freely if you need any help
with the integration of this patch (ex. if you want some code written in a
different way).

Also it is outside the scope of your responsibilities, but I hope that N800
xserver can become fully Nokia 770 compatible at source level to provide better
hardware abstraction for maemo platform. There are some patches for it here:
https://garage.maemo.org/tracker/index.php?func=detail&aid=531&group_id=164&atid=683

It should be even possible to get Xv working on Nokia 770, though I doubt it is
worth efforts from the practical point of view. But it may be interesting if
one has a goal to provide the same set of features on all devices.

Comment 6 Daniel Stone nokia

2007-11-15 01:34:48 UTC

FWIW, I completely dropped the ball on this one and didn't get it in for
ITOS2008, but I'll try to shove it in for the first enhancement release, and
I'll try to fix the XSP bits as well.  I don't really have time to get Xv going
on 770, but patches are, of course, welcome.

Comment 7 Daniel Stone nokia

2008-06-13 00:23:33 UTC

This has been included for Diablo.

Comment 8 Andre Klapper maemo.org

2008-08-20 01:33:59 UTC

(In reply to comment #7)
> This has been included for Diablo.

According to the internal report (which does not fit perfectly in scope with
this bug but also covers it) this has been fixed internally, but wasn't part of
the last update.
Correcting Target Milestone.

Comment 9 Daniel Stone nokia

2008-08-20 01:38:09 UTC

Erm, it was integrated both to Fremantle and to Diablo.

xorg-server (1:1.3.99.0~git20070321-0osso20082301) unstable; urgency=low

  * Add XV_AUTOPAINT_COLORKEY property.
  * Optimise fbSolid for ARM (fixes: NB#85619).
  * Optimise YV12/I420 -> YUV420 conversion (fixes: NB#85053, MB#1278).

 -- Daniel Stone <daniel.stone@nokia.com>  Mon, 02 Jun 2008 14:50:53 +0300

Comment 10 Andre Klapper maemo.org

2008-08-20 02:34:13 UTC

(In reply to comment #9)
> Erm, it was integrated both to Fremantle and to Diablo.
> xorg-server (1:1.3.99.0~git20070321-0osso20082301) unstable; urgency=low
>  -- Daniel Stone <daniel.stone@nokia.com>  Mon, 02 Jun 2008 14:50:53 +0300

Comment about accepting xorg-server 1:1.3.99.0~git20070321-0osso20082301 was
made on August 4th, and I can't see any comment from beginning of June in the
report.
Anyway, you know better, I don't have access to those logs. :-)

Comment 11 Daniel Stone nokia

2008-08-20 11:38:24 UTC

Yeah, it took a while first for me to upload, and then for it to get accepted. 
2nd June was simply the first time I bumped the version.