Bug 12470 – Check mate needs to be parsed and processed in Miniature

Bug 12470 - Check mate needs to be parsed and processed in Miniature


Summary:	Check mate needs to be parsed and processed in Miniature

Status:	VERIFIED FIXED

Product:	Miniature
Component:	Engine
Version:	master
Platform:	All All

Importance:	High normal (vote)
Target Milestone:	0.5
Assigned To:	unassigned
QA Contact:	general

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2011-10-19 19:14 UTC by Quim Gil
Modified:	2011-11-01 07:45 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Quim Gil (reporter) 2011-10-19 19:14:17 UTC

SOFTWARE VERSION: 
master

EXACT STEPS LEADING TO PROBLEM: 
1. Play a game and either check mate or get checkmated


EXPECTED OUTCOME: 
The end game dialog explains that a check mate has happened as the reason for
victory / defeat.

ACTUAL OUTCOME: 

remoteSide.id "vanished"

This happens because Miniature is still not parsing the check mate FICS
message. The frontend is expecting Miniature.ReasonCheckmated to be used in
this situation, alternatively falling back to the "vanished" reason.

REPRODUCIBILITY: 
always

OTHER COMMENTS: 

The FICS message:

FICS: "{Game 401 (quimi vs. cphkt) cphkt checkmated} 1-0" 

(I believe this is the only one used, no matter who wins)

Comment 1 Quim Gil (reporter) 2011-10-19 19:16:31 UTC

mikhas, do you think we can take this one from 0.5 still? Getting a correct
reason for a checkmate looks like a pretty basic feature and its implementation
is a no-brainer. fwiw the related string in the frontend is already there and
translated, meaning that we are not affecting the string freeze.

Comment 2 Quim Gil (reporter) 2011-10-20 22:25:10 UTC

Committed to 0.5.

Comment 3 Michael Hasselmann 2011-11-01 03:34:46 UTC

Fixed in master with commit 1ad02f7bc0164ef5fc8b35a9ae725079ecdbffcb.

Comment 4 Quim Gil (reporter) 2011-11-01 07:45:37 UTC

Verified. Thank you for the fix.