Bug 12464 – Players with rating of less 1000 points cannot reliably use Miniature

Bug 12464 - Players with rating of less 1000 points cannot reliably use Miniature


Summary:	Players with rating of less 1000 points cannot reliably use Miniature

Status:	VERIFIED FIXED

Product:	Miniature
Component:	General
Version:	master
Platform:	All All

Importance:	High normal (vote)
Target Milestone:	0.5
Assigned To:	unassigned
QA Contact:	general

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2011-10-16 09:59 UTC by Quim Gil
Modified:	2011-11-04 07:38 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Quim Gil (reporter) 2011-10-16 09:59:15 UTC

SOFTWARE VERSION: 
master

EXACT STEPS LEADING TO PROBLEM: 
1. Boot Miniature and login to FICS
2. Watch the list of seek games in the SDK log and SeekGames 

EXPECTED OUTCOME: 
Same Standard games appear in both sides.

ACTUAL OUTCOME: 
The seeks of players with <1000 points appear in SDK log, but not in SeekGames.

REPRODUCIBILITY: 
always

The problem is probably trivial? An extra space in "( nnn)" is used for players
with 3 digit ratings):

FICS: "quimi ( 954) seeking 57 58 rated standard [white] ("play 90" to
respond)"

miniature.cc parses only:

\\(([0-9+]+)\\)

Comment 1 Quim Gil (reporter) 2011-10-16 10:03:24 UTC

Proposing this bug for 0.5 since it's quite a loss of functionality and the fix
looks simple.

mikhas, what do you think?

PS: now I understand why I never found "bad" players to play against my poor 6
years old son, having to deal always with +1000 rating opponents.  :)

Comment 2 Quim Gil (reporter) 2011-10-16 10:17:52 UTC

There seems to be more problems related with players with 3 digit ratings. I
know it sounds weird but playing with MiniatureTest in Miniature I get this:

- No problem with games against 4 digit players or guests.

- Against user quimi (the only I have scoring <1000 points):

* local and remote player ratings appear always as 0 in OnlineBoard
* time and increment also appear as 0 in OnlineBoard
* game always appears as unrated in OnlineBoard

The SDK logs reflect the rating of players and information of the game
properly.

mikhas, I will send you the password of the user "quimi" so you can test at
will.

Comment 3 Michael Hasselmann 2011-10-16 13:45:04 UTC

(In reply to comment #0)
> The problem is probably trivial? An extra space in "( nnn)" is used for players
> with 3 digit ratings):
> 
> FICS: "quimi ( 954) seeking 57 58 rated standard [white] ("play 90" to
> respond)"
> 
> miniature.cc parses only:
> 
> \\(([0-9+]+)\\)

d'oh (read: how embarrassing!)

Comment 4 Michael Hasselmann 2011-10-17 04:19:04 UTC

Fixed with commit 5de1fb21bd267d2170cde20e71a1865cb14690be.

Comment 5 Quim Gil (reporter) 2011-10-18 08:53:15 UTC

Ah great!

Comment 6 Quim Gil (reporter) 2011-10-20 02:07:25 UTC

Hum it seems that <1000 players can't launch new seeks either. Filing this hier
since I don't have time to open a new bug and investigate.

Can it be that we are having the same problem processing:

FICS: "Creating: quimi ( 885) dumdumy ( 734) rated blitz 5 12"

1. Log in with a <1000 user
2. Create a new seek
3. Someone accepts

Expected: game starts

Actually: server and opponent start the game, Miniature keeps showing SeekGame.
If the user tries to select other games the answer in the SDK log is expected:

FICS: "fics% You cannot accept seeks while you are playing a game." 

User gets stuck.

Comment 7 Quim Gil (reporter) 2011-10-20 07:40:29 UTC

Another problem that only quimi aka <1000 player only seems to suffer:
sometimes he is checkmated but no end game dialog appears. The game simy gets
stuck (probably finished as usual for the remote side). Can this also have a
relation with the 3 digit rating?

Comment 8 Michael Hasselmann 2011-10-20 12:59:33 UTC

(In reply to comment #7)
> Another problem that only quimi aka <1000 player only seems to suffer:
> sometimes he is checkmated but no end game dialog appears. The game simy gets
> stuck (probably finished as usual for the remote side). Can this also have a
> relation with the 3 digit rating?

Odd, I was thinking I fixed that together with the seeks. If you dont open new
bug then this one needs to be reopened.

Comment 9 Michael Hasselmann 2011-10-22 15:00:28 UTC

(In reply to comment #7)
> Another problem that only quimi aka <1000 player only seems to suffer:
> sometimes he is checkmated but no end game dialog appears. The game simy gets
> stuck (probably finished as usual for the remote side). Can this also have a
> relation with the 3 digit rating?

Yes, it'll be all related. I need to go through the regexes and replace any
occurrence of rating parsing with the proper macro.

Changing bug title to be more generic, and thus, reopen bug.

Comment 10 Michael Hasselmann 2011-11-01 03:43:16 UTC

Sorry, cannot repo. Tried with quimi's account – was able to send off seeks and
another registered player was able to accept, too. Checkmate handling does not
involve any rating numbers → WFM

Comment 11 Quim Gil (reporter) 2011-11-04 07:37:54 UTC

The big bugs have been resolved but there is still something fishy about
checkmates in games with both players with <1000 points. Today Quimi got a mate
with 0.5 RC and there was no black dialog to be seen.

I will open a specific bug for this though. Apart from this detail the rest
seems to work.