Bug 12424 - [Discussion] OnlineBoard: Implement a better game's end dialog
: [Discussion] OnlineBoard: Implement a better game's end dialog
Status: NEW
Product: Miniature
UI
: master
: All All
: High major (vote)
: ---
Assigned To: Quim Gil
: general
:
:
: 12411 12433 12435
:
  Show dependency tree
 
Reported: 2011-09-16 22:42 UTC by Uwe Kaminski
Modified: 2014-03-08 10:29 UTC (History)
2 users (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Uwe Kaminski (reporter) 2011-09-16 22:42:18 UTC
At the moment every time a game ends there is a default message "[opponents
name] vanished! [color] wins".

This dialog should be improved in content an function:

1. Insert the reason of the game's end
2. Show how much rating points the player (and opponent) got or lost
3. Write always from the players perspective and call his/her name if logged in
as non-guest account
4. Implement four buttons in this dialog: "Back to board" / "Seek new game" /
"Challange [opponents name]" / "Chat with opponent"

What do you think?
Comment 1 Quim Gil 2011-09-16 22:58:46 UTC
Absolutely. Feel free putting all your ideas here. I will start working on this
next week.

I also think that there must be an option to accept the dialog and just stay in
OnlineBoard. Once I got the dialog without being sure whether I got a mat or
just run out of time.  :)  In any case many players will want to see the final
position. Some will also want to have some words with the opponent before
leaving.

This means that in such circumstance the Back button must allow you to go to
SeekGame.
Comment 2 Quim Gil 2011-09-20 02:27:49 UTC
Started working on this:

http://gitorious.org/miniature/miniature/commit/002e48a778a3a36142c0431eb6b508d863d83514
http://gitorious.org/miniature/miniature/commit/39e5b0a1c17e26b3aaf75d5fae6c193daf630170

(In reply to comment #0)
> 1. Insert the reason of the game's end

Done

> 2. Show how much rating points the player (and opponent) got or lost

Partially done. The backend needs to provide the value of the new rating. Also
I'm not sure about showing the opponent's rating. Less is more in a small
mobile screen and not even FICS console (or eBoard) seems to bother?

> 3. Write always from the players perspective and call his/her name if logged in
> as non-guest account

It simply says "You won!" or "You lose...", which is equally good for guests
and registered users.

> 4. Implement four buttons in this dialog: "Back to board" / "Seek new game" /
> "Challange [opponents name]" / "Chat with opponent"

Gosh, you like to add buttons!  ;)

Now there is two: "Rematch" and "Seek games".

The new dialogs are smaller, allowing to type/read in the chat area as long as
there is an opponent still on the other side.

About "Back to board", it might make sense but then the next thing users will
want is to store games.  ;)  Letting the user back to the board means that we
must edit the options to the Back icon not to show the "Resign", etc. Still not
sure about this.

Now a secondary effect is that you can see the clock running in the background.
I have to look the way to stop it.

Tomorrow more.
Comment 3 Quim Gil 2011-09-21 01:53:37 UTC
Corrected the algorythm:
https://gitorious.org/miniature/miniature/commit/7a11c977d228fad77bd95ff159dfb01477e3bd31
and now adjudicates victories/defeats properly to the local user.

Investigating and testing I have found other cases where a proper dialog can't
be shown currently due to values missing from the backend. I have filed the
corresponding bugs, and I have set the bugs that are blocking this one.

I think this is as far as I can go efficiently without mikas around. In the
meantime I better move onto other tasks.
Comment 4 Quim Gil 2011-10-10 09:04:25 UTC
The end game dialog is ready for 0.5, unless someone wants to introduce more
improvements (could be myself if I have time).

Now the dialog will explain the result and the reason, giving options to go
back to SeekGame or to the board. The latter is nice since you might want to
analyze  the final position of the game and perhaps you want still chat with
your opponent.

The reasons expected to work in 0.5 are: checkmate, draw, out of time and the
catch-all "has vanished".

Once the game is over the "beck" menu doesn't show anymore Resign & Draw.
Instead, it leads directly to SeekGame.