Bug 12414 - OnlineBoard: Implement dialog for abort requests
: OnlineBoard: Implement dialog for abort requests
Status: NEW
Product: Miniature
UI
: master
: All All
: High normal (vote)
: ---
Assigned To: Quim Gil
: general
:
:
: 12411
:
  Show dependency tree
 
Reported: 2011-09-13 09:48 UTC by Uwe Kaminski
Modified: 2011-12-09 08:26 UTC (History)
3 users (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Uwe Kaminski (reporter) 2011-09-13 09:48:18 UTC
SOFTWARE VERSION: 
master

EXACT STEPS LEADING TO PROBLEM: 
1. Run miniature in NON TESTING MODE and connect to server
2. Start a game (Player using Miniatur, opponent using an other client) with
player as white -> it's player's turn 
3. Player: Make a move (1. e4)
4. Opponent: Make a move (1. ...e5)
5. Player: Make a move (2. d4)
6. Opponent: Request "Abort game" 

EXPECTED OUTCOME:
I. A non modal dialog (not overlaping the board) appears: "Opponent requests
abort." + button "accept" + button "decline"
IIa. On accept: game's end dialog (which finally leads to SeekGames screen)
IIb. On decline: nothing happens and game goes on

ACTUAL OUTCOME: 
Nothing happens and both sides are unable to make a move (red square appears).

REPRODUCIBILITY: 
always

This feature is relevant for 0.4 IMHO, because it depends on an opponent's
command and ends in a state where player is unable to end the game regularly.

More Information regarding abort in FICS help files:
http://www.freechess.org/Help/HelpFiles/abort.html
Comment 1 Uwe Kaminski (reporter) 2011-09-13 09:51:38 UTC
This bug is related to test case 1.4.1 and 1.4.2 in the list of test cases:
http://wiki.maemo.org/Miniature/Development/testcases

Game log containing FICS log is available here:
http://wiki.maemo.org/Miniature/Development/testcases/ficslog141

Key line:
FICS: "okmko would like to abort the game; type "abort" to accept."
Comment 2 Quim Gil 2011-09-18 08:13:58 UTC
Proposing for 0.5 - needs to be confirmed.
Comment 3 Quim Gil 2011-09-27 01:13:02 UTC
(In reply to comment #1)
> Key line:
> FICS: "okmko would like to abort the game; type "abort" to accept."

UI implemented although I can't test this until the backend pieces are in place
as well. See
http://gitorious.org/miniature/miniature/commit/f908b9fb55edffc8c0834a824447a5d0ca6d8ef3
for more details.
Comment 4 Quim Gil 2011-09-27 01:33:35 UTC
By the way, at http://miniature-chess.org/wiki/Test_cases you say: 

> A non modal dialog (not overlaping the board) appears: 

The current implementation does overlap the board. The reason is simple: I
couldn't find anywhere else to make it fit. I tried in the chat area: looks
ugly and weird. 

Let's see how the current behavior works esp when the opponent is trying to
distract the local user with multiple requests. In principle FICS prevents
multiple requests from being sent by telling the user "You have alredysent a
request" or something. Still, better to be sure and test it when the backend
functionality is implemented.
Comment 5 Uwe Kaminski (reporter) 2011-09-27 22:12:25 UTC
(In reply to comment #4)
> By the way, at http://miniature-chess.org/wiki/Test_cases you say: 
> 
> > A non modal dialog (not overlaping the board) appears: 
> 
> The current implementation does overlap the board. The reason is simple: I
> couldn't find anywhere else to make it fit. I tried in the chat area: looks
> ugly and weird. 

A better(?) solution would be an information banner which could be shown in
whatever screen (Main Game / SeekGames / OnlineBoard). The advantage would be
the needed space. The "banner" also could be an icon somewhere.

After tapping onto this banner the proiposed dialog could appear and in this
case it could overlap important areas like the chess board.

If you agree with this idea I would open a "non-modal 2 step dialog"-bug which
could be assigned to related bugs which need such a dialog to be solved.

> Let's see how the current behavior works esp when the opponent is trying to
> distract the local user with multiple requests. In principle FICS prevents
> multiple requests from being sent by telling the user "You have alredysent a
> request" or something. Still, better to be sure and test it when the backend
> functionality is implemented.

Multiple requests may be impossible, sure. But it could be very unfair to get a
request in the final part of a game. It would break the attention of the player
or make the player's clock running out of time so this implementation should be
a workaround until we have a better. On the other hand you are right: Let's see
how the current behaviour works first. :)
Comment 6 Quim Gil 2011-10-08 10:02:13 UTC
(In reply to comment #0)
> ACTUAL OUTCOME: 
> Nothing happens and both sides are unable to make a move (red square appears).

I have tested and it doesn't happen to me with the latest version.

It happened though when sending a draw request... but after doing CleanAll,
RebuildAll & deploy everything worked as expected.

Therefore this issue is not as big as described in the first comment and
therefore we leave it for post-0.5, as agreed in the IRC meeting.
Comment 7 Uwe Kaminski (reporter) 2011-12-09 07:53:33 UTC
In 0.5 there is no possibility to abort a game. Only "resign" is available as
option.

An option "abort" is needed:
* Until the second move is done an abort request does not need a confirmation
* after move one, the opponent has to agree the request