Bug 12411 - OnlineBoard: Implement game end dialog for abort during move 1
: OnlineBoard: Implement game end dialog for abort during move 1
Status: NEW
Product: Miniature
UI
: master
: All All
: High enhancement (vote)
: ---
Assigned To: unassigned
: general
:
:
:
: 12410 12414 12424 12382
  Show dependency tree
 
Reported: 2011-09-12 23:55 UTC by Uwe Kaminski
Modified: 2011-12-09 09:02 UTC (History)
3 users (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Uwe Kaminski (reporter) 2011-09-12 23:55:14 UTC
SOFTWARE VERSION: 
master

EXACT STEPS LEADING TO PROBLEM: 
1. Run miniature in NON TESTING MODE and connect to server
2. Start a game (Player using Miniatur, opponent using an other client) with
player as black -> it's opponent's turn 
3. Opponent: Request "Abort game" 

OR

1. Run miniature in NON TESTING MODE and connect to server
2. Start a game (Player using Miniatur, opponent using an other client) with
player as white -> it's player's turn 
3. Player: Make a move (1. e4)
4. Opponent: Request "Abort game" 

EXPECTED OUTCOME: 
I. Game ends immidiately and no rating modification happens
II. Dialog with explanation appears: "Game aborted on move 1"
 + button "Ok"
III. SeekGames Window appears 

ACTUAL OUTCOME: 
Game ends immidiately and no rating modification happens but nothing happens in
Miniature. The only way go on is the "Convinient: Back to MainPage" item in the
back menu

REPRODUCIBILITY: 
always

This feature is relevant for 0.4 IMHO, because it depends on an opponent's
command

More Information regarding abort in FICS help files:
http://www.freechess.org/Help/HelpFiles/abort.html
Comment 1 Uwe Kaminski (reporter) 2011-09-12 23:57:25 UTC
1.2.1 and 1.2.2
Comment 2 Uwe Kaminski (reporter) 2011-09-12 23:58:44 UTC
This bug is related to test case 1.2.1 and 1.2.2 in the list of test cases:
http://wiki.maemo.org/Miniature/Development/testcases
Comment 3 Quim Gil 2011-09-13 03:04:20 UTC
At least game abortion requests should be handled in 0.4, I agree. About
sending an abortion request... that too although closing the app will lead to
the same goal.  :)  I see totally the point but I'm reluctant to add more stuff
to 0.4 unless mikhas says he is fine too.

I guess game abortion requests are not parsed by the backend? jukey, can you
paste here the FICS text to parse? You can see it in the SDK logs. Thanks!
Comment 4 Uwe Kaminski (reporter) 2011-09-13 03:11:48 UTC
(In reply to comment #3)
> I guess game abortion requests are not parsed by the backend? jukey, can you
> paste here the FICS text to parse? You can see it in the SDK logs. Thanks!

At least for abort on move 1 I have a log:
http://wiki.maemo.org/Miniature/Development/testcases/ficslog122

Key lines are:
FICS: "Your opponent has aborted the game on move one." 
FICS: "{Game 598 (okmko vs. GuestWKWG) Game aborted on move 1} *"

For normal abort (move > 1) there is an other message but I'll handle this in a
seperate bug.
Comment 5 Quim Gil 2011-09-13 22:25:58 UTC
There has been some progress: now games aborted do get a dialog. But it's a
generic one for the catch-all that mikhas has implemented for 0.4.

Let's have the 0.4 release and then let's look to what needs to  be improved.
Comment 6 Quim Gil 2011-09-18 08:13:08 UTC
Proposing for 0.5 - needs to be confirmed.
Comment 7 Quim Gil 2011-09-24 00:44:24 UTC
Let's agree on the values and strings to be used in this dialog:


Title of the dialog:

Miniature.ResultAborted --> "Game aborted"

Miniature.ReasonLocalAborts --> "You didn't want to play forward"
Miniature.ReasonRemoteAborts --> "%1 didn't want to play forward"

gameResolutions.newRatings --> "No ratings adjustment done"

Regarless of move 0, 1 or afterward. The related Miniature.Result & Reason need
to be created.
Comment 8 Uwe Kaminski (reporter) 2011-09-24 21:31:32 UTC
(In reply to comment #7)
> Let's agree on the values and strings to be used in this dialog:
[...]
> Miniature.ReasonLocalAborts --> "You didn't want to play forward"
> Miniature.ReasonRemoteAborts --> "%1 didn't want to play forward"

Maybe it's better to write:
"You didn't want to resume the game" instead of "to play forward"?

But the whole dialog seems to be fine now.