Bug 12409 – Miniature doesn't handle rating values properly after the first move

Bug 12409 - Miniature doesn't handle rating values properly after the first move


Summary:	Miniature doesn't handle rating values properly after the first move

Status:	CLOSED FIXED

Product:	Miniature
Component:	General
Version:	master
Platform:	All All

Importance:	High normal (vote)
Target Milestone:	0.4
Assigned To:	unassigned
QA Contact:	general

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2011-09-12 04:04 UTC by Quim Gil
Modified:	2011-09-18 08:00 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Quim Gil (reporter) 2011-09-12 04:04:38 UTC

SOFTWARE VERSION: 
master

EXACT STEPS LEADING TO PROBLEM: 
1. Play games either as registered user or as anonymous against registered
users.

EXPECTED OUTCOME: 
Your own rating and the rating of your opponents are correct.

ACTUAL OUTCOME: 
They seem to end up as "0". They seem to appear correctly in the seek list and
in the user zone at the bottom of SeekGame, but starting a game they seem to
get converted in 0 no matter what.

REPRODUCIBILITY: 
always

OTHER COMMENTS: 
I have introduced the values localSide.rating and remoteSide.rating. Are these
the correct ones or...?

Comment 1 Quim Gil (reporter) 2011-09-13 08:36:37 UTC

One scenario that can be reproduced:

1. Login with MiniatureTest in eBoard/PC, and as guest in miniature.
2. Launch from MiniatureTest: seek 57 58 unrated
3. Accept fast from Miniature.

At the beginning MiniatureTest will show the correct rating, but after the
first move it will change to 0.

The SDK log:

FICS: "MiniatureTest (1767) seeking 57 58 unrated standard ("play 67" to
respond)" 
FICS: "fics% " 
FICS: "Creating: MiniatureTest (1767) GuestQPRJ (++++) unrated standard 57 58" 
FICS: "{Game 99 (MiniatureTest vs. GuestQPRJ) Creating unrated standard
match.}" 
FICS: "" 
FICS: "<12> rnbqkbnr pppppppp -------- -------- -------- -------- PPPPPPPP
RNBQKBNR W -1 1 1 1 1 0 99 MiniatureTest GuestQPRJ -1 57 58 39 39 3420 3420 1
none (0:00) none 1 0 0" 
FICS: "fics% " 
FICS: "<12> rnbqkbnr pppppppp -------- -------- ----P--- -------- PPPP-PPP
RNBQKBNR B 4 1 1 1 1 0 99 MiniatureTest GuestQPRJ 1 57 58 39 39 3420 3420 1
P/e2-e4 (0:00) e4 1 0 0" 

This test above was done with MiniatureTest playing white. The same happens
when playing black:

FICS: "MiniatureTest (1767) seeking 57 58 unrated standard [black] ("play 9" to
respond)" 
FICS: "fics% " 
FICS: "Creating: GuestHTZD (++++) MiniatureTest (1767) unrated standard 57 58" 
FICS: "{Game 88 (GuestHTZD vs. MiniatureTest) Creating unrated standard
match.}" 
FICS: "" 
FICS: "<12> rnbqkbnr pppppppp -------- -------- -------- -------- PPPPPPPP
RNBQKBNR W -1 1 1 1 1 0 88 GuestHTZD MiniatureTest 1 57 58 39 39 3420 3420 1
none (0:00) none 0 0 0" 
void Game::Frontend::Miniature::confirmMove() move confirmed ... 
virtual void Game::Command::Move::exec(Game::Dispatcher*,
Game::AbstractEngine*) "e2e4" 
FICS: "fics% " 
FICS: "<12> rnbqkbnr pppppppp -------- -------- ----P--- -------- PPPP-PPP
RNBQKBNR B 4 1 1 1 1 0 88 GuestHTZD MiniatureTest -1 57 58 39 39 3420 3420 1
P/e2-e4 (0:00) e4 0 0 0"

Comment 2 Quim Gil (reporter) 2011-09-13 08:40:48 UTC

... and fwiw it also happens playing as registered user in Miniature.

Type from the PC client:

seek 57 58 rated white

The ratings of both sides are correct in the initial position. After a first
move both change to 0.

FICS: "MiniatureTest (1767) seeking 57 58 rated standard [white] ("play 63" to
respond)" 
FICS: "fics% "  
FICS: "Creating: MiniatureTest (1767) QuimGil (1562) rated standard 57 58" 
FICS: "{Game 137 (MiniatureTest vs. QuimGil) Creating rated standard match.}" 
FICS: "" 
FICS: "<12> rnbqkbnr pppppppp -------- -------- -------- -------- PPPPPPPP
RNBQKBNR W -1 1 1 1 1 0 137 MiniatureTest QuimGil -1 57 58 39 39 3420 3420 1
none (0:00) none 1 0 0" 
FICS: "fics% " 
FICS: "<12> rnbqkbnr pppppppp -------- -------- ----P--- -------- PPPP-PPP
RNBQKBNR B 4 1 1 1 1 0 137 MiniatureTest QuimGil 1 57 58 39 39 3420 3420 1
P/e2-e4 (0:00) e4 1 0 0"

Comment 3 Michael Hasselmann 2011-09-13 19:31:22 UTC

Fixed with commit 50d53496b365aa99086d8d3a915688025425fa07.

Comment 4 Quim Gil (reporter) 2011-09-13 20:33:50 UTC

Yep, works now. Thanks!