Bug 12396 - Implement dialog for challanges
: Implement dialog for challanges
Status: NEW
Product: Miniature
UI
: master
: All All
: Medium enhancement (vote)
: ---
Assigned To: unassigned
: general
:
:
:
:
  Show dependency tree
 
Reported: 2011-09-11 12:46 UTC by Uwe Kaminski
Modified: 2011-10-06 19:13 UTC (History)
3 users (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Uwe Kaminski (reporter) 2011-09-11 12:46:47 UTC
SOFTWARE VERSION:
master

EXACT STEPS LEADING TO PROBLEM: 
0. Make sure to get the application output (e.g. in Qt Creators output window)
1. run Miniature in NON TESTING MODE
2. Login using a real account
3. wait until a challenge happens or login using an other client and challenge
the Miniature player

EXPECTED OUTCOME: 
A dialog should appear:
"Challange from $USER ($RATING)." + button "accept" + button "decline"

ACTUAL OUTCOME: 
nothing happens

REPRODUCIBILITY: 
always

FICS LOG:
FICS: "Challenge: bingopm (1015) jukey (1035) rated blitz 10 0." 
FICS: "Your blitz rating will change:  Win: +14,  Draw: -1,  Loss: -16" 
FICS: "Your new RD will be 73.2" 
FICS: "You can "accept" or "decline", or propose different parameters."
Comment 1 Quim Gil 2011-09-11 18:24:44 UTC
If I understand properly your description... are you missing just the dialog or
the fact that the game doesn't start?

More than a dialog, the problem seems to be that Miniature doesn't understand
that someone has answered your new seek as registered user - or that it is
handling it manually when it should b automatically?

The desired scenario is:

1. Log in as registered user.
2. Launch a new seek.
3. A new game automatically starts when someone accepts it.

There seems to be some irregularities related with registered users and/or
rated games - no wonder since until now we have been testing mainly with
unregistered users and unrated games.
Comment 2 Uwe Kaminski (reporter) 2011-09-11 21:48:38 UTC
(In reply to comment #1)
> If I understand properly your description... are you missing just the dialog or
> the fact that the game doesn't start?

There are two different ways to start a game in FICS:

1. seek: This is a game offer available for all player online which are
matching the criteria the seek request containing.

2. match: A exact defined player is challenged. E.g. I could challange you,
Quim, if I know your username and we are connected to the server both at the
same time. 

More information about match:
http://www.freechess.org/Help/HelpFiles/match.html

This bug regards the second case (match). If you are connected to FICS as real
user you will get match offers from time to time.

IMHO this could be a feature for a post 0.4 version because it's no problem for
the player. (What the eye does not see, the heart does not grieve over.)

> More than a dialog, the problem seems to be that Miniature doesn't understand
> that someone has answered your new seek as registered user - or that it is
> handling it manually when it should b automatically?

As written abov this is the second case. If I challange a player using the
match command this player has to accept or decline the challenge using the
command "accept" or "decline". As far as I know it is only possible to
challange an other player if (s)he is not playing a game in the same moment.

> The desired scenario is:
> 
> 1. Log in as registered user.
> 2. Launch a new seek.
> 3. A new game automatically starts when someone accepts it.

This works as expected. What does not work is challenging (this bug) and see
game offers while logged in as real user: Bug 12398

> There seems to be some irregularities related with registered users and/or
> rated games - no wonder since until now we have been testing mainly with
> unregistered users and unrated games.

Yes it seems. I normally play as logged in user so I also was not aware of this
differences until I begun to use Miniature. :)
Comment 3 Quim Gil 2011-09-12 01:12:15 UTC
Ok, understood now. Taking this away from 0.4, then.
Comment 4 Quim Gil 2011-09-21 01:45:22 UTC
This is actually not only relevant in SeekGame. imgo it is even more relevant
when you finish a game and the opponent requests a rematch, which is a frequent
use case. Now Miniature can't accept those even if you want you, and this makes
you appear as a uncool player...

The strings:

"Challenge: GuestSSKF (----) GuestWKNX (----) unrated blitz 2 12." 
"You can "accept" or "decline", or propose different parameters." 

So we have several things:

1 - "Rematch" request to the same opponent after finishing a game.
2 - Accept rematch from opponent after finishing a game.
3 - Match someone in SeekGame.
4 - Accept a match request in SeekGame.

1 and 2 have the priority. We need to agree on the UI flow first.
Comment 5 Quim Gil 2011-09-27 01:54:11 UTC
The more I think about this one, the more I see the complexity:

- When you are in SeekGame the logical situation to request or receive a
request for a match is when a player with a pending adjourned game is around.
We would need to know when that happens and present it in the UI.

- When you are in OnlineGame the logical situation is to request or receive a
request with the opponent you just played with, but in some situations the
"Rematch" button doesn't make any sense e.g. opponent vanished, requested
adjourn, started a new game with someone else. We would need to show or not the
button based on these parameters.

I propose to leave this one until we have fixed the many other opened items. It
requires good discussion and planning.