Bug 12365 – Promotion does not work

Bug 12365 - Promotion does not work


Summary:	Promotion does not work

Status:	CLOSED FIXED

Product:	Miniature
Component:	UI
Version:	master
Platform:	other Harmattan

Importance:	High major (vote)
Target Milestone:	0.4
Assigned To:	unassigned
QA Contact:	general

URL:
Keywords:

Depends on:
Blocks:	12342
	Show dependency tree

Reported:	2011-09-01 03:09 UTC by Uwe Kaminski
Modified:	2011-09-18 07:57 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Uwe Kaminski (reporter) 2011-09-01 03:09:49 UTC

SOFTWARE VERSION: 
master

EXACT STEPS LEADING TO PROBLEM: 
1. Run Minature and start a game
2. play until a pawn arrives at the opposite border of the chess board (for
white: line 8) 

EXPECTED OUTCOME: 
Pawn should be promoted to a Queen in 99% of all causes. There should be a
solution for the 1% cause when a promotion to an other piece would fit better
but that should be part of an other bug report.

ACTUAL OUTCOME: 
No promotion is done. Te pawn is staying on the field.

REPRODUCIBILITY: 
always

Comment 1 Quim Gil 2011-09-01 20:13:06 UTC

I believe it does work when playing real games and not in Testing Mode. CCing
mikhas since he should know better.

Uwe, it would be great if you could run a real test with yourself  :)  PC -
N950. Just set the Testing Mode off, select the seek you have launched from
your PC and get your pawns to the end of the line.

In theory your FICS account has a default piece for promotion (e.g. Queen) and
that would be the one automatically used.

We don't have yet a UI for piece selection but you are invited to file a bug
and I will be happy to work on this for a future release.

Comment 2 Michael Hasselmann 2011-09-01 20:22:32 UTC

I will add a quick auto-promote to queen hack for 0.4.

Comment 3 Quim Gil 2011-09-02 22:57:33 UTC

The current behavior is:

- Local side promotion: Miniature sees still a pawn while the opponent sees a
queen. The pawn gets converted to a queen after the opponent makes a move. Not
so bad.

- Remote side promotion: Miniature sees nothing changing (the pawn is still in
the 7th row and the timer is on the opponent's side as if he wouldn't have
moved). The opponent sees his pawn logically converted in a Queen. From that
point the game gets stuck since no side can move. REALLY BAD.

Comment 4 Michael Hasselmann 2011-09-10 22:33:50 UTC

Fixed with commit 6c3d210fd3c065e39af5bccf4b808e40dfbe7fa6.

Comment 5 Quim Gil 2011-09-12 01:51:46 UTC

Yep, it works for both sides. Thanks!