Bug 12358 – Miniature UI doesn't handle user's new seeks

Bug 12358 - Miniature UI doesn't handle user's new seeks


Summary:	Miniature UI doesn't handle user's new seeks

Status:	CLOSED FIXED

Product:	Miniature
Component:	UI
Version:	master
Platform:	All All

Importance:	High major (vote)
Target Milestone:	0.4
Assigned To:	Michael Hasselmann
QA Contact:	general

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2011-08-29 22:38 UTC by Quim Gil
Modified:	2011-09-18 07:56 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Quim Gil (reporter) 2011-08-29 22:38:03 UTC

SOFTWARE VERSION: 
0.3

EXACT STEPS LEADING TO PROBLEM: 
1. Login to FICS
2. Press "New"
3. A new seek dialog will appear. Press "Yes"

EXPECTED OUTCOME: 
The seek is visible in the UI, so the user knows for sure that is active. If
more seeks are created all of them should be visible in the UI. When a
challenge is accepted by an opponent then the ongoing seeks are cancelled and
the OnlineBoard starts.

ACTUAL OUTCOME: 
New seeks are not visible anywhere. OnlineBoard is activated immediately.


REPRODUCIBILITY: 
always

Comment 1 Quim Gil (reporter) 2011-08-29 22:40:05 UTC

I will work on the UI at SeekGame to reflect one or more new challenges created
by the user.

Comment 2 Quim Gil (reporter) 2011-08-30 17:04:28 UTC

Setting to High priority, as agreed yesterday with mikhas at #miniature. This
feature is now part of the 0.4 release content. I'm working on the UI part as
we speak, hoping to have something up today.

Comment 3 Quim Gil (reporter) 2011-08-30 18:15:46 UTC

"New seek" UI committed to master:

https://gitorious.org/miniature/miniature/commit/3e44d444cfc192ed6f0684abb6a581009ba1006d

- When the user confirms a new seek, the challenge is shown at the
bottom of the list.
- This new seek element plays nicely together with the highlighted item.
- Currently the UI is based on the idea that there is only one new seek
at a time: if the user launches another new seek the previous one must
be cancelled.
- PENDING: connecting to the backend so an actual new seek is launched
(to be disabled in Testing Mode). The new seek should appear on the list
of seeks dimmed (like it happens with the highlighted item).

What do you think about cancelling a new seek? Currently there is no way,
uynless you launch a new seek or accept another challenge. If you think
cancelling is good then the UI could be:

1. Tap on the new seek element or the spinner next to it.
2. Cancellation dialog shows up Yes/No.
3. Yes removes the new seek from view and cancels it through the backend.

Reassigning to mikhas. If there are other UI improvements let me know.

Comment 4 Michael Hasselmann 2011-09-11 01:16:09 UTC

Can we drop this bug for 0.4? Apparently, sending out a single seek with
Miniature works, so at least the priority and severity of this bug is
questioned (by me). And this bug would require creating a new model for the
player's seek, which is not difficult per se but could require a lot of more
silly code :-)

Comment 5 Quim Gil (reporter) 2011-09-11 02:22:09 UTC

I was not aware that a new seek could be initiated by the user!

Then yes, I agree. Both cancelling an ongoing challenge and adding more seeks
are additional features that, if someone misses them, can be discussed after
0.4.

Resolving. I could verify since I have already played one game from a new seek
issued by me but I want to give it another go later today.

Comment 6 Quim Gil (reporter) 2011-09-12 04:11:24 UTC

Verifying. This works like a charm for one seek at a time.