Bug 12355 – List of games: Change possible time control filter options

Bug 12355 - List of games: Change possible time control filter options


Summary:	List of games: Change possible time control filter options

Status:	CLOSED FIXED

Product:	Miniature
Component:	UI
Version:	master
Platform:	All All

Importance:	Medium enhancement (vote)
Target Milestone:	---
Assigned To:	Uwe Kaminski
QA Contact:	general

URL:
Keywords:	easyfix

Depends on:
Blocks:
	Show dependency tree

Reported:	2011-08-29 00:55 UTC by Uwe Kaminski
Modified:	2011-10-12 01:08 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
Fix for this Enhancement as Diff (1.60 KB, application/octet-stream) 2011-08-29 15:39 UTC, Uwe Kaminski	Details
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Uwe Kaminski (reporter) 2011-08-29 00:55:31 UTC

OFTWARE VERSION: master-branch (2011-08-28)

EXACT STEPS LEADING TO PROBLEM: 
1. Run Miniature
2. Join FICS as guest using the "Join as guest" button.
3. Tap onto the "3" (second button) on top of the list in the green filter area

EXPECTED OUTCOME:
According to the most used time control modes on FICS (
http://www.ficsgames.com/stats/tcontrols.html ) the following values should be
available: 
The list of values for "Time" contains: *, 0, 1, 2, 3, 4, 5, 7, 10, 15, 20, 30,
60
The list of values for "Increment" contains: *, 0, 1, 3, 5, 12, 30

ACTUAL OUTCOME:
The list of values for minutes contains: *, 1, 3, 5, 10, 15, 30, 60
The list of values for seconds contains:  *, 0, 1, 3, 6, 12, 30

REPRODUCIBILITY: 
always

OTHER COMMENTS:
The default values for both options be * and the setting the last time was
chosen. But that is stuff for an other bug entry.

Comment 1 Quim Gil 2011-08-29 01:00:07 UTC

I agree, and is easy to fix. I came up with the current values basically
guessing. That URL is useful, thanks!

Comment 2 Uwe Kaminski (reporter) 2011-08-29 15:39:45 UTC

Created an attachment (id=3406) [details]
Fix for this Enhancement as Diff

Please let me know if I should deliver small patsches like this in an other
way.

Comment 3 Quim Gil 2011-08-29 17:22:15 UTC

Patch committed, thank you!

https://gitorious.org/miniature/miniature/commit/03da26eed1780b401c270768c1b2f64a22309b02

Bugzilla attachment is fine for simple commits like this one. Just make sure
the extension of the file is .patch

Please verify whenever you have a chance.

Comment 4 Michael Hasselmann 2011-08-29 17:48:15 UTC

Please select "patch" for the attachement next time or plain text. Otherwise, I
cannot quickly view it with my browser. Thanks ;-)

Comment 5 Uwe Kaminski (reporter) 2011-08-29 22:46:45 UTC

Works as expected.

The Diff-File was created by Qt Creator which always added .qml as extension to
the file. Nex time I'll rename it manually afterwards.

Comment 6 Quim Gil 2011-08-29 23:42:34 UTC

One thing, I just pushed a commit to set the defaults to 2 12 instead of "*"
"*" as a quick solution to the problem of creating new seeks: currently the
value taken is the one selected for the seek. We need to discuss further how to
handle those greencards for new seeks, or whether we should remove them, but
this is part of a different bug (that you are invited to open with a proposal,
if you wish).

Comment 7 Michael Hasselmann 2011-08-29 23:55:47 UTC

(In reply to comment #5)
> Works as expected.
> 
> The Diff-File was created by Qt Creator which always added .qml as extension to
> the file. Nex time I'll rename it manually afterwards.

This was about the attachment upload field in Bugzilla ;-)