maemo.org Bugzilla – Bug 12344
Miniature chat in FICS doesn't work
Last modified: 2011-09-18 07:55:06 UTC
You need to log in before you can comment on or make changes to this bug.
SOFTWARE VERSION: 0.3 in N9 EXACT STEPS LEADING TO PROBLEM: 1. Get to the FICS board. 2. Chat EXPECTED OUTCOME: Chat works, or at least a real FICS console content can be seen there. ACTUAL OUTCOME: It doesn't work, which is no wonder since it's just a static text string.
If we want 0.4 to be submitted in Ovi then we can't have "UI demos". This means that we either make the chat work or remove it from the OnlineBoard UI. I'm for the second option, unless mikhas says this is trivial and he is ready to do it. I recall playing FICS with a freeware app for Symbian in an E71 that didn't have any means to chat/communicate withe the opponent and it was just fine. Feedback, please.
It's just a "tell" command away, so … uhm … let's have it for 0.4?
Ok, deal. And with this... the Miniature 0.4 content is crystal clear! No more changes unless there is a extremely good reason.
Partially fixed with commit d769b9427629d14fc8c3ac6c12f43a6c2625e788. Your FICS opponent will always receive the full message, but for the local player it is clipped (damn you FICS protocol for being so wrong and inefficient). Also, the Listview in the QML UI clips the text instead of wrapping it (so this actually shadows the "clipping" done by the backend - you wouldn't be able to see longer messages anyway. @Quim: can you check the text wrapping issue? Am already asking here, too: http://developer.qt.nokia.com/forums/viewthread/9600/
If you chat in a game and then use the convenient link to mainpage, when you play again you still see the old messages there. I couldn't try finishing a game normally yet.
(In reply to comment #4) > @Quim: can you check the text wrapping issue? Am already asking here, too: > http://developer.qt.nokia.com/forums/viewthread/9600/ Got the right answer in that forum thread, thanks! Fix committed: http://gitorious.org/miniature/miniature/commit/ec75bc591e31df5f267000c8fdf2e5a942f8bacc Now there are only two remarkable problems related with presentation of the text: - Yes, remote messages get cut because of that "\" the FICS server introduces to "wrap" the text manually. The local side won't see what is said after that. This is a backend problem. - When the local side posts a long message, it may get beyond the ChatBkg even if its anchor.bottom is changed to the opponentZone.top. Everything is fine when another short post is sent by any player. This is a frontend problem and I'll look further into it.
(In reply to comment #6) > - When the local side posts a long message, it may get beyond the ChatBkg even > if its anchor.bottom is changed to the opponentZone.top. Everything is fine > when another short post is sent by any player. This is a frontend problem and > I'll look further into it. Partially fixed with https://gitorious.org/miniature/miniature/commit/04d8d0c1ead7215a373191e1674f65fb6d66edda The problem now is that only the remote side messages force onRowsInserted: chatLog.positionViewAtEnd() - the messages posted by the local side are appended at the end but at some point get out of the view. I guess it has to do with the AnchorChange? This might be a minor problem in real situations, where it is expected that the opponent talks more than the Miniature user... I'll investigate more tomorrow. I'm also half way on improving the jumps from small to big chat screen. This is why I commented the animations, which makes the jump from small to big look better. I still need to improve the jump to big to small, where there is a glitch showing the board for an instant where the small chat window should be. More about this also tomorrow. In any case, I believe that as soon as the remote side messages are shown by Miniature withoug cuts we are good enough for 0.4...
(In reply to comment #7) > The problem now is that only the remote side messages force onRowsInserted: > chatLog.positionViewAtEnd() - the messages posted by the local side are > appended at the end but at some point get out of the view. > > I guess it has to do with the AnchorChange? I asked at http://developer.qt.nokia.com/forums/viewthread/9655/
Remote messages no longer get cut: 598bb34610917c5eccfff8f062a396977f60a218. Consider this bug fixed. For UI glitch mentioned in comment 7 & 8: if non-trivial fix, then file new bug. I don't consider it necessary for 0.4 though → FIXED.
Yes, now long comments from the remote side get all printed. Agreed, this is good enough for 0.4. Verifying. The bug about the UI glitches can be found at Bug 12413 - The chat log doesn't show the last line when the local user posts I'll keep chasing it there.
Just setting severity to 'major', for history. :)