Bug 11499 – Check for new episodes / Add new podcast buttons sizes

Bug 11499 - Check for new episodes / Add new podcast buttons sizes


Summary:	Check for new episodes / Add new podcast buttons sizes

Status:	RESOLVED FIXED

Product:	gPodder
Component:	General
Version:	unspecified
Platform:	N900 Maemo

Importance:	Unspecified normal (vote)
Target Milestone:	---
Assigned To:	Thomas Perl
QA Contact:	general

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2010-10-31 00:24 UTC by John Veness
Modified:	2010-11-24 23:15 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
gpodder landscape buttons (33.44 KB, image/png) 2010-11-21 19:15 UTC, John Veness	Details
phone landscape buttons (33.14 KB, image/png) 2010-11-21 19:16 UTC, John Veness	Details
gpodder portrait buttons (39.78 KB, image/png) 2010-11-23 00:12 UTC, John Veness	Details
phone portrait buttons (38.22 KB, image/png) 2010-11-23 00:13 UTC, John Veness	Details
visual diff of old layout (gpodder vs. phone) (84.09 KB, image/png) 2010-11-24 23:10 UTC, Thomas Perl	Details
visual diff of new layout (gpodder vs. phone) (68.30 KB, image/png) 2010-11-24 23:11 UTC, Thomas Perl	Details
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description John Veness (reporter) 2010-10-31 00:24:58 UTC

The two buttons:

- Check for new episodes
- Add new podcast

in the main view are different sizes in portrait mode than in landscape. They
seem too tall in portrait, and slightly too short in landscape, when compared
to the buttons that appear when you click "Add new podcast" for example.

Comment 1 Thomas Perl 2010-11-20 21:45:16 UTC

Closing as INVALID. This is actually the desired behaviour. Compare this to the
built-in phone application's UI - it's the same there.

Comment 2 John Veness (reporter) 2010-11-21 19:15:24 UTC

Ah, I didn't realise you were copying the phone UI. (Not that the behaviour is
necessarily correct in that app either). Still, if that's your model then the
buttons are still a bit too short in landscape, see attached screenshots. But I
won't argue if that's how you want it.

Comment 3 John Veness (reporter) 2010-11-21 19:15:57 UTC

Created an attachment (id=3206) [details]
gpodder landscape buttons

Comment 4 John Veness (reporter) 2010-11-21 19:16:14 UTC

Created an attachment (id=3207) [details]
phone landscape buttons

Comment 5 Thomas Perl 2010-11-22 01:40:13 UTC

Reopening as per comment 2. We should fix the height in landscape mode and also
the padding/spacing between the buttons and the screen borders. Is the button
size in portrait mode also different from the phone app?

Comment 6 John Veness (reporter) 2010-11-23 00:11:42 UTC

I had to install load-applet to take portrait screenshots as opening the
keyboard for Ctrl+Shift+P moves apps to landscape. Anyway, I attach
comparisons. There is a slight difference but not so much as in landscape.

Comment 7 John Veness (reporter) 2010-11-23 00:12:57 UTC

Created an attachment (id=3219) [details]
gpodder portrait buttons

Comment 8 John Veness (reporter) 2010-11-23 00:13:08 UTC

Created an attachment (id=3220) [details]
phone portrait buttons

Comment 9 Thomas Perl 2010-11-24 23:10:44 UTC

Created an attachment (id=3222) [details]
visual diff of old layout (gpodder vs. phone)

Old UI: Phone UI in background, gPodder UI with 50% opacity and inverted colors
in foreground. Shows layout differences in landscape mode.

Comment 10 Thomas Perl 2010-11-24 23:11:08 UTC

Created an attachment (id=3223) [details]
visual diff of new layout (gpodder vs. phone)

New UI: Phone UI in background, gPodder UI with 50% opacity and inverted colors
in foreground. Shows layout differences in landscape mode.

Comment 11 Thomas Perl 2010-11-24 23:15:19 UTC

Fixed in Git (see attachment 3223 [details]). The fix will be part of the next release.

Commit: http://gpodder.org/commit/a90d615e