Bug 8731

Summary: Memory leaks in widget HildonAnimationActor
Product: [Maemo Official Platform] Desktop platform Reporter: Vlad Vasiliev <vlad>
Component: hildon-widgetsAssignee: Alberto Garcia Gonzalez <agarcia>
Status: VERIFIED FIXED QA Contact: hildon-libs-bugs
Severity: normal    
Priority: Unspecified CC: agarcia, andre_klapper
Version: 5.0/(2.2009.51-1)   
Target Milestone: 5.0/(10.2010.19-1)   
Hardware: All   
OS: Maemo   
Attachments: Source of test
Valgrind's log

Description Vlad Vasiliev (reporter) 2010-01-31 23:43:36 UTC 
SOFTWARE VERSION:

SDK FREMANTLE_X86 
libhildon-2.2.3

EXACT STEPS LEADING TO PROBLEM: 
I downloaded source of libhildon-2.2.3
apt-get source libhildon
Took simple test from hildon-animation-actor.c and modified it  see attach
(test_hildon_animation.c)

Compiled it:
gcc -g -o test  -I/usr/include -I/usr/X11R6/include `pkg-config --cflags  
hildon-1 `  `pkg-config --libs  hildon-1 ` test_hildon_animation.c
Run under valgring:
cp test /usr/bin/test && run-standalone.sh run-with-memcheck  /usr/bin/test
And I saw memory leaks in log file (see attach memcheck-test-1873.log)



EXPECTED OUTCOME:
Widget without memory leaks

ACTUAL OUTCOME:
Widget with memory leaks

REPRODUCIBILITY:


EXTRA SOFTWARE INSTALLED:

OTHER COMMENTS:

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.9.0.7)
Gecko/2009032803 Iceweasel/3.0.6 (Debian-3.0.6-1)
Comment 1 Vlad Vasiliev (reporter) 2010-01-31 23:44:31 UTC 
Created an attachment (id=2176) [details]
Source of test
Comment 2 Vlad Vasiliev (reporter) 2010-01-31 23:45:57 UTC 
Created an attachment (id=2177) [details]
Valgrind's log
Comment 3 Vlad Vasiliev (reporter) 2010-01-31 23:53:18 UTC 
I have forgotten to tell that you should press on the button in a window for 
destroying of Acter for checking memory leaks.
Comment 4 Alberto Garcia Gonzalez 2010-02-01 14:12:57 UTC 
Thanks for spotting this

diff --git a/hildon/hildon-animation-actor.c b/hildon/hildon-animation-actor.c
index beaf8f5..6283835 100644
--- a/hildon/hildon-animation-actor.c
+++ b/hildon/hildon-animation-actor.c
@@ -291,6 +291,7 @@ hildon_animation_actor_finalize                (GObject
*object)

        g_object_unref (priv->parent);
     }
+    G_OBJECT_CLASS (hildon_animation_actor_parent_class)->finalize (object);
 }

 static void
Comment 5 Alberto Garcia Gonzalez 2010-02-01 14:17:49 UTC 
Fixed:

http://maemo.gitorious.org/hildon/hildon/commit/24e39bf44ac4f2be5a79a11eb5dea36cdd55b003
Comment 6 Andre Klapper maemo.org 2010-03-15 20:54:25 UTC 
Setting explicit PR1.2 milestone (so it's clearer in which public release the
fix will be available to users).

Sorry for the bugmail noise (you can filter on this message).