maemo.org Bugzilla – Full Text Bug Listing
|Summary:||ohmd fails if discover_plugins cannot open plugin directory|
|Product:||[Maemo Official Platform] System software||Reporter:||Tommi Saviranta <wnd+maemo>|
|Status:||RESOLVED FIXED||QA Contact:||ohm-bugs|
|Priority:||Low||CC:||andre_klapper, eero.tamminen, tri|
|Attachments:||make discover_plugins() to return sane values on failed opendir()|
SOFTWARE VERSION: http://repository.maemo.org fremantle/sdk/free ohm 0.1.2-0maemo30.1+0m5 EXACT STEPS LEADING TO PROBLEM: 1. Missing ohm plugin directory (/usr/lib/ohm) 2. Run ohmd EXPECTED OUTCOME: ohmd runs without plugins (or exits gracefully). ACTUAL OUTCOME: ohmd segfaults. REPRODUCIBILITY: Always. EXTRA SOFTWARE INSTALLED: Irrelevant. OTHER COMMENTS: If opendir() fails, discover_plugins() returns FALSE (instead of NULL) without touching number of plugins. Trivial fix is to set *nplugin = 0 and return NULL. User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a1pre) Gecko/20091129 Minefield/3.7a1pre
Created an attachment (id=1660) [details] make discover_plugins() to return sane values on failed opendir()
Thanks for reporting this & providing a patch!
(In reply to comment #2) > Thanks for reporting this & providing a patch! > Andre, any idea this patch will be in PR1.2?
> Andre, any idea this patch will be in PR1.2? According to internal bug tracker, the patch is included into Ohmd coming in PR1.2. Andre hasn't verified it yet though.
Thanks for the patch again! This has been fixed for the next public update. To answer popular followup questions: * Nokia does not announce release dates of public updates in advance. * There is currently no access to these internal, non-public build versions. A Brainstorm proposal to change this exists at http://maemo.org/community/brainstorm/view/undelayed_bugfix_releases_for_nokia_open_source_packages-002/