maemo.org Bugzilla – Full Text Bug Listing
|Summary:||hildon-games-wrapper crashes in hgw_conf_request_string if gconf key has no value|
|Product:||[Maemo Official Applications] Games||Reporter:||Javier S. Pedro <maemo>|
|Status:||VERIFIED FIXED||QA Contact:||games-general-bugs|
SOFTWARE VERSION: hildon-games-wrapper 1.9.4 (diablo & fremantle). STEPS TO REPRODUCE THE PROBLEM: 1. Call hgw_conf_request_string with a unassigned GConf key without default value or no schema. EXPECTED OUTCOME: hgw_gconf_request_string returning something other than HGW_ERR_NONE. ACTUAL OUTCOME: Crash. REPRODUCIBILITY: always OTHER COMMENTS: The library has no -dbg package. I'll try to build my own and make a proper coredump latter (or even a patch if it's easy enough). An initial guess is that gconf sends a dbus message the library doesn't parse correctly. This has been bugging me for a while because I have to ensure no value is unset before spawning the game from osso-games-startup, but I guess the builtin games already take care of that for themselves.
Created an attachment (id=1398) [details] testcase Attaching a simple app currently crashing, build in Fremantle SDK with gcc -o test -lhgw test.c . Before running, make sure to "export HGW_EXEC_SERVICE=com.blabla.bla" and "export HGW_EXEC_SERVICE=com.blabla.bla". This fails with the following backtrace: #0 0x00000000 in ?? () #1 0xf7e99d8b in _dbus_type_reader_recurse (reader=0xffffcfc8, sub=0xffffcf90) at dbus-marshal-recursive.c:1020 #2 0xf7e9ec2c in dbus_message_iter_recurse (iter=0xffffcfc0, sub=0xffffcf88) at dbus-message.c:1883 #3 0xf7fdec95 in get_value_from_daemon (conn=0x804caa8, path=0x80486a7 "/apps/unset_key", dest=0x8049820, type=1) at hgw_conf.c:161 #4 0xf7fdef3c in hgw_conf_request_string (ctx=0x804e2b8, value_path=0x80486a7 "/apps/unset_key", dest=0x8049820 "") at hgw_conf.c:72 #5 0x08048572 in main ()
Created an attachment (id=1399) [details] proposed patch And my proposed fix. This introduces a new HgwError, HGW_ERR_NO_VALUE, but of course that can be debated.
integrated to pr1.2
This has been fixed in package hildon-games-wrapper 1.9.4-5+0m5 which is part of the internal build version 10.2010.08-12 (Note: 2009/2010 is the year, and the number after is the week.) A future public update released with the year/week later than this internal build version will include the fix. (This is not always already the next public update.) Please verify that this new version fixes the bug by marking this bug report as VERIFIED after the public update has been released and if you have some time. To answer popular followup questions: * Nokia does not announce release dates of public updates in advance. * There is currently no access to these internal, non-public build versions. A Brainstorm proposal to change this exists at http://maemo.org/community/brainstorm/view/undelayed_bugfix_releases_for_nokia_open_source_packages-002/
Setting explicit PR1.2 milestone (so it's clearer in which public release the fix will be available to users). Sorry for the bugmail noise (you can filter on this message).
Verified under x86 SDK: hgw now returns HGW_ERR_NO_VALUE ("res: -23" in testcase). Thanks!