Bug 7164 – osso-xterm dark grey color shown as black

Bug 7164 - (int-151577) osso-xterm dark grey color shown as black

(int-151577)
Summary:	osso-xterm dark grey color shown as black

Status:	RESOLVED FIXED

Product:	Utilities
Component:	X Terminal
Version:	5.0:(10.2010.19-1)
Platform:	All Maemo

Importance:	Low normal with 4 votes (vote)
Target Milestone:	5.0/Community-SSU
Assigned To:	unassigned
QA Contact:	osso-xterm-bugs

URL:
Keywords:	community-fremantle, patch

Depends on:
Blocks:
	Show dependency tree

Reported:	2009-12-20 19:18 UTC by Heikki Kallasjoki
Modified:	2011-01-31 15:44 UTC (History)
CC List:	6 users (show)

See Also:

Attachments
One-line patch to make bright black dark grey. (400 bytes, patch) 2009-12-20 19:19 UTC, Heikki Kallasjoki	Details
Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Heikki Kallasjoki (reporter) 2009-12-20 19:18:21 UTC

SOFTWARE VERSION:

1.2009.42-11

EXACT STEPS LEADING TO PROBLEM:

1. Open osso-xterm ("X Terminal")
2. Type: echo -e '\x1b[30;1m foo \x1b[0m'

EXPECTED OUTCOME:

Output of the word "foo" in a dark grey color.

ACTUAL OUTCOME:

Output of the word "foo" in black.

REPRODUCIBILITY:

always

OTHER COMMENTS:

The libvte4 version 1:0.16.14-0mh9.m5 used in Maemo 5 1.2009.42-11 initializes
both the "black" and the "bright black" colors to the same (black) color in the
default palette.  This is arguably correct (black is black, after all), but
more commonly "bright black" is instead rendered as dark gray, the same way as
all the other colors.  

Googling suggests that this has been already fixed (in 2008), but the version
included on the N900 seems to still have the same problem.  The attached
one-line patch, applied to libvte4 version 1:0.16.14-0mh9 from the SVN
repository of the osso-xterm project in Garage, fixes the problem for me.  (It
simply changes the range so that colors 8..15, instead of only 9..15, are made
brighter in the default palette.)

Comment 1 Heikki Kallasjoki (reporter) 2009-12-20 19:19:31 UTC

Created an attachment (id=1812) [details]
One-line patch to make bright black dark grey.

Comment 2 Andre Klapper maemo.org

2009-12-21 19:01:28 UTC

Thanks for reporting this & the patch!

Comment 3 Lucas Maneos 2010-01-22 10:11:29 UTC

*** Bug 8382 has been marked as a duplicate of this bug. ***

Comment 4 Thomas Perl 2010-01-22 10:51:59 UTC

Updating version field: Still an issue in 5.0/(2.2009.51-1).

Comment 5 Stas 2010-07-26 04:36:41 UTC

I am still affected by this bug (as of 10.2010.19-1.002) - it makes several
applications unusable over ssh/telnet.

How would I go about applying Heikki's patch?

Comment 6 Heikki Kallasjoki (reporter) 2010-07-26 09:05:17 UTC

Updating version field again, is still broken in 10.2010.19-1.

Stas, if you're willing to trust a random binary, you can fetch the two .debs
at http://zem.fi/~fis/vte/ and install them with "dpkg -i" as root. This should
be the version I'm using in my phone at the moment.

Alternatively, if you have the N900 SDK installed, something like "apt-get
source libvte4" + "cd vte-0.16.14" + "patch -p1 < ../the.patch.file" +
"dpkg-buildpackage -rfakeroot" ought to work, but I can't test this right now.

Comment 7 Adam Borowski 2010-07-26 10:55:05 UTC

The patch works correctly.

It's a trivial one, what is the reason it hasn't been applied to the official
resporitory?

Comment 8 Thomas Perl 2011-01-11 14:15:47 UTC

This patch is going into the Community SSU at
http://gitorious.org/community-ssu/vte

Comment 9 Andrew Flegg maemo.org

2011-01-29 23:52:32 UTC

Should this now be RESOLVED (and even VERIFIED, if possible) as the fix is
included in the Community SSU, as thp notes?

Suggested bug lifecycle:
  http://talk.maemo.org/showpost.php?p=923088&postcount=47

Commit:
 
http://gitorious.org/community-ssu/vte/commit/8ba1088e3bf0e9da21b251f2971222a0ed0950c1

Comment 10 Mohammad Abu-Garbeyyeh 2011-01-31 12:43:30 UTC

Marking this as RESOLVED FIXED, tested with Community SSU (Testing) enabled
using X Terminal and the command provided.

If anyone still has this bug with the CSSU enabled (refer to
http://wiki.maemo.org/Community_SSU), feel free to reopen the bug :)