Comment 1 Ferenc Szekely 2010-05-04 14:30:18 UTC

Agreed. The horizontal line (ie. a border of h1 and h2) and a bit of padding
will help reading. Please file an other bug for the numbering.

Comment 2 Dave Neary 2010-05-04 15:23:52 UTC

That is of course a matter of taste.

Maemo's wiki stype is modelled on the maemo.org stylesheet, if we add likes to
H1 and H2 here, we should do it everywhere (and, for my part, I would
disagree).

Then again, neither Ferenc or myself are designers, perhaps we should ask the
opinion of Tim.

Comment 3 Dave Neary 2010-12-14 12:43:19 UTC

To accomplish this, I changed this:

h1, h2, h3
{
    margin: 0.5em 0;
}

to this:

h1, h2, h3
{
    margin: 0.5em 0;
    border-bottom-width: 1px;
    border-bottom-style: solid;
    border-bottom-color: rgb(170,170,170);
}

in http://static.maemo.org/style_maemo2009/css/master.css (stored in svn here:
http://vcs.maemo.org/svn/maemo2midgard/midgard-data/style/maemo2009/static/css/master.css)

I didn't think it was an improvement, but as I said in my last comment (before
the bug got closed), I'd fall in line if Tim said it were better.

Comment 4 Tim Samoff 2010-12-15 01:39:33 UTC

This sounds like a valid request to me. Regardless of tastes, sticking as close
to MediaWiki standards, while inserting our own bit of style, will make the UX
for uninitiated readers more seamless.

Comment 5 Dave Neary 2010-12-15 12:04:10 UTC

Committed in

Comment 6 Dave Neary 2010-12-15 12:10:04 UTC

Oops!

Fix committed in revision 1697 of maemo2midgard. It seems like there's no
viewvc interface for maemo2midgard online any more, so I can't point to the
revision here.

Thanks to Niels for updating the CSS live, this change should now be in effect
on all maemo.org sites.

Dave.

Comment 7 Tim Samoff 2010-12-15 19:18:58 UTC

Looks great. (There could be some adjustment in overall line-height between
some elements now, but that's an entirely different bug.)

Comment 8 Tim Samoff 2010-12-15 23:58:25 UTC

Weirdness has occurred on the Planet page:

http://maemo.org/news/planet-maemo/

Notice the double lines under the Planet Maemo heading. Also, the lines under
all of the blog post titles looks odd (and busy).

Anyway, to change the style for this specific page? (I guess with different
classes for the headings.)

Comment 9 Dave Neary 2010-12-16 01:26:16 UTC

Just to document how I go about these kind of things:

1. DOM inspector -> inspect Planet Maemo
2. Click on that horizontal bar (highlights a DIV in the page)
3. select "CSS rules" in the top right
4. Select "#container #content #main .planet-entry" - note CSS rules:

background-image: url("../img/bg-header.gif");
background-repeat: repeat-x;

That background-image is referring to
http://static.maemo.org/style_maemo2009/img/bg-header.gif - and the CSS file
referenced is http://static.maemo.org/style_maemo2009/css/planet.css - which is
in svn at
http://vcs.maemo.org/svn/maemo2midgard/midgard-data/style/maemo2009/static/css/planet.css
(so you can "svn co http://vcs.maemo.org/svn/maemo2midgard/", update the CSS,
and attach a patch here).

Dave.

Comment 10 Andrew Flegg 2010-12-21 11:50:08 UTC

Created an attachment (id=3251) [details]
Example of Planet right now

Planet is now pretty sub-optimal. Look at the current situation, screenshot
attached:

* There are two separators under the "Planet Maemo" title.
* There's a separator under the article title.
* The content of the MWKN feed contains headings which are also getting
separators.
* There's a separator between each article and the next.
* There's then the separator under each article's title.

Too many lines!

Comment 11 Dave Neary 2010-12-21 12:15:09 UTC

Attempted to fix this in revision #1700.

* Reduced top & bottom margin for planet entries
* Remove the two-tone horizontal bar under Planet Maemo and between planet
entries

This means there is now just an underline under h1 and h2 headings. mwkn is a
strange one from this point of view, because it starts with a h1, and then each
of the items on the front page are h2s. Hopefully it's atypical enough that the
underlining of both the article title & subheadings won't bother people too
much?

Comment 12 Tim Samoff 2010-12-21 17:13:30 UTC

I think this is acceptable -- still not perfect (sorry, my bandwidth is limited
right now) -- but much better than before. Thanks, Dave.

Comment 13 Dave Neary 2010-12-21 17:31:14 UTC

Based on IRC feedback, I've reverted the underlined headers for everything
except the wiki (should take affect when Niels updates the static CSS after
revision #1701 of maemo2midgard).

(In reply to comment #13)
> Based on IRC feedback, I've reverted the underlined headers for everything
> except the wiki (should take affect when Niels updates the static CSS after
> revision #1701 of maemo2midgard).

I´m not expert on CSS, but how about using !important property in planet.css to
override master.css?

border-bottom: none !important;

(check syntax, just out of my head)

It´s not nice & clean way but it´s something.

Comment 15 Dave Neary 2010-12-22 18:16:42 UTC

No need. Style for h1, h2 added to http://wiki.maemo.org/MediaWiki:Common.css
and removed from main.css, underlining should only happen in the wiki now.

Closed for good?

Dave.